Files
clean-architecture-frontend…/tests/unit/fixture-node-modules.test.ts
T
DongHyeonka f0a8582c72
frontend-quality-gates / merge / static checks (pull_request) Successful in 1m33s
frontend-quality-gates / merge / tests (pull_request) Successful in 12m9s
frontend-quality-gates / merge / browser tests (pull_request) Successful in 5m35s
frontend-quality-gates / FE-GATE-017 / diagram-review (pull_request) Skipped
frontend-quality-gates / main / self-tests and removal drills (pull_request) Skipped
frontend-quality-gates / FE-GATE-014 / config-compatibility (pull_request) Skipped
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (pull_request) Skipped
frontend-quality-gates / FE-GATE-026 / lab-performance (pull_request) Skipped
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (pull_request) Skipped
frontend-quality-gates / external-vulnerability-provider (pull_request) Skipped
frontend-quality-gates / external-provenance-provider (pull_request) Skipped
frontend-quality-gates / promote-verified-immutable-candidate (pull_request) Skipped
frontend-quality-gates / deploy-promoted-release (pull_request) Skipped
frontend-quality-gates / FE-GATE-019 / hosting-header (pull_request) Skipped
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (pull_request) Skipped
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (pull_request) Skipped
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (pull_request) Skipped
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (pull_request) Skipped
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (pull_request) Skipped
frontend-quality-gates / FE-GATE-018 / field-web-vitals (pull_request) Skipped
fix(ci): 시험 fixture가 PR job의 게이트 선택 env를 물려받지 않는다
PR run의 merge job은 CI_PR_BASE_REF=main을 둔다. 임시 폴더에서
scripts/run-ci-gate.ts를 띄우는 시험은 env를 그대로 물려줬고, 자식은
그 폴더에 없는 config/ci/pr-gate-selection.json을 열다 ENOENT로
죽었다(runner run 291, tests/unit/ci-gate-failure.test.ts:102).
FE-GATE-005가 깨졌고, scaffold 사본의 test:coverage가 같은 시험을 돌려
FE-GATE-020도 깨졌다. desktop verify.sh merge는 ci_env에 이 변수가 없어
이 길을 타지 않았다.

fixture는 PR의 checkout이 아니므로 그 안의 게이트는 늘 전부 돈다.
FIXTURE_PNPM_ENVIRONMENT가 CI_PR_BASE_REF를 빈 값(main run과 같음)으로
둔다. scaffold 드릴·제거 드릴·provider fixture·run-ci-gate를 띄우는 시험이
모두 이 상수를 쓰므로 한 곳에서 끈다.
- ci-gate-failure 시험은 바깥 env와 상관없이 PR job env(main)를 넣고
  띄운다. 그래서 desktop에서도 CI의 조건을 늘 시험한다.
- run-ci-gate를 띄우는 시험은 이 상수를 써야 한다는 검사를
  fixture-node-modules 시험에 더했다. 그 검사가 상수 없이 띄우던
  ci-workflow-generation 시험 하나를 찾았다. 그 시험은 preflight에서
  먼저 막혀 지금은 가려지지 않지만, 상수를 주고 막힌 이유를 단언한다.

버린 대안:
- prGateSkipReason이 경로표가 없으면 전부 돌기: 원인은 시험 env다. 진짜
  checkout에서 경로표가 없으면 크게 실패하는 편이 맞다.
- verify.sh ci_env에 CI_PR_BASE_REF를 두기: desktop merge가 게이트를
  건너뛰게 되어 「merge 단계 전부 통과」 판정과 맞지 않는다.

위험·한계:
- 시스템 컨테이너(scripts/run-in-system-container.sh)는 CI_PR_BASE_REF를
  넘기지 않는다. 그래서 FE-GATE-013은 PR run에서도 늘 전부 돈다(안전한
  쪽). 이 커밋은 그대로 둔다.

검증(desktop):
- RED: 9f8b2c1c에서 `env CI_PR_BASE_REF=main node scripts/run-vitest.ts
  run tests/unit/ci-gate-failure.test.ts` rc=1, run 291과 같은 ENOENT.
- 고친 뒤 시험 4파일(ci-gate-failure, fixture-node-modules,
  pr-gate-selection, ci-workflow-generation) 471개 통과, 바깥
  CI_PR_BASE_REF=main 있을 때와 없을 때 둘 다.
- 상수의 새 줄만 빼면 바깥 env 없이도 ci-gate-failure 시험이 같은
  ENOENT로 실패한다. 새 검사는 상수를 안 쓰던 시험을 찾아 실패했다.
2026-11-14 03:40:46 +09:00

312 lines
12 KiB
TypeScript

import { spawnSync } from "node:child_process";
import {
copyFile,
lstat,
mkdtemp,
mkdir,
readdir,
readFile,
rm,
stat,
writeFile,
} from "node:fs/promises";
import { tmpdir } from "node:os";
import path from "node:path";
import { afterEach, describe, expect, it } from "vitest";
import {
FIXTURE_PNPM_ENVIRONMENT,
linkFixtureNodeModules,
} from "../../scripts/lib/fixture-node-modules.ts";
import { selectRepositoryPaths } from "../../scripts/lib/repository-layout.ts";
import { childProcessTimeout } from "../helpers/child-process-timeout.ts";
/**
* A removal or provider fixture runs `pnpm` inside a throwaway copy of the
* repository. pnpm does not recognise the modules directory it finds there and
* purges it, and with `CI=true` it does so without a prompt. When
* `<fixture>/node_modules` was a single directory symlink, that purge followed
* the link and deleted the repository's own installed dependencies mid-run —
* a test suite uninstalling the workspace it was running in.
*/
describe("fixture node_modules linking", () => {
async function sourceTree() {
const source = await mkdtemp(path.join(tmpdir(), "fixture-source-"));
const modules = path.join(source, "node_modules");
await mkdir(path.join(modules, "left", "lib"), { recursive: true });
await mkdir(path.join(modules, "@scope", "right"), { recursive: true });
await mkdir(path.join(modules, ".bin"), { recursive: true });
await writeFile(path.join(modules, "left", "lib", "index.js"), "export default 1;\n");
await writeFile(path.join(modules, "@scope", "right", "package.json"), "{}\n");
await writeFile(path.join(modules, ".modules.yaml"), "{}\n");
return source;
}
it("survives a recursive delete of the fixture's node_modules", async () => {
const source = await sourceTree();
const fixture = await mkdtemp(path.join(tmpdir(), "fixture-root-"));
try {
await linkFixtureNodeModules(fixture, source);
// The fixture resolves the same packages...
expect(
await readFile(
path.join(fixture, "node_modules/left/lib/index.js"),
"utf8",
),
).toContain("export default 1;");
expect(
(await readdir(path.join(fixture, "node_modules"))).sort(),
).toEqual([".bin", ".modules.yaml", "@scope", "left"]);
// ...and this is exactly what pnpm's purge does.
await rm(path.join(fixture, "node_modules"), {
recursive: true,
force: true,
});
// The repository's real dependencies are untouched.
expect(
await readFile(
path.join(source, "node_modules/left/lib/index.js"),
"utf8",
),
).toContain("export default 1;");
expect(
await stat(path.join(source, "node_modules/@scope/right/package.json")),
).toBeDefined();
expect(
(await readdir(path.join(source, "node_modules"))).sort(),
).toEqual([".bin", ".modules.yaml", "@scope", "left"]);
} finally {
await rm(source, { recursive: true, force: true });
await rm(fixture, { recursive: true, force: true });
}
});
// pnpm rewrites `.pnpm-workspace-state-v1.json` in place when it runs inside
// the fixture. Through a symlink that write landed in the repository's own
// state file, so the next pnpm command there re-verified the install.
it("copies the pnpm state files instead of linking them", async () => {
const source = await sourceTree();
const fixture = await mkdtemp(path.join(tmpdir(), "fixture-root-"));
const stateFiles = [".modules.yaml", ".package-map.json", ".pnpm-workspace-state-v1.json"];
try {
for (const file of stateFiles) {
await writeFile(path.join(source, "node_modules", file), `{"projects":{"${source}":{}}}\n`);
}
await linkFixtureNodeModules(fixture, source);
for (const file of stateFiles) {
const copied = path.join(fixture, "node_modules", file);
expect((await lstat(copied)).isSymbolicLink(), file).toBe(false);
await writeFile(copied, `{"projects":{"${fixture}":{}}}\n`);
expect(await readFile(path.join(source, "node_modules", file), "utf8"), file)
.toBe(`{"projects":{"${source}":{}}}\n`);
}
} finally {
await rm(source, { recursive: true, force: true });
await rm(fixture, { recursive: true, force: true });
}
});
// A copied state file still names the repository as the validated project,
// so pnpm inside the fixture re-verified the install and started one through
// the linked directories. Pointing it at the fixture keeps pnpm from
// installing into a tree whose packages are shared with the repository.
it("points the copied workspace state at the fixture root", async () => {
const source = await sourceTree();
const fixture = await mkdtemp(path.join(tmpdir(), "fixture-root-"));
const statePath = ".pnpm-workspace-state-v1.json";
try {
await writeFile(
path.join(source, "node_modules", statePath),
JSON.stringify({
lastValidatedTimestamp: 1,
projects: { [source]: { name: "template", version: "0.1.0" } },
settings: { dev: true },
}),
);
const before = Date.now();
await linkFixtureNodeModules(fixture, source);
const state = JSON.parse(
await readFile(path.join(fixture, "node_modules", statePath), "utf8"),
);
expect(state.projects).toEqual({
[fixture]: { name: "template", version: "0.1.0" },
});
expect(state.lastValidatedTimestamp).toBeGreaterThanOrEqual(before);
expect(state.settings).toEqual({ dev: true });
} finally {
await rm(source, { recursive: true, force: true });
await rm(fixture, { recursive: true, force: true });
}
});
it("creates node_modules as a real directory, never a symlink", async () => {
const source = await sourceTree();
const fixture = await mkdtemp(path.join(tmpdir(), "fixture-root-"));
try {
await linkFixtureNodeModules(fixture, source);
const entry = await lstat(path.join(fixture, "node_modules"));
expect(entry.isSymbolicLink()).toBe(false);
expect(entry.isDirectory()).toBe(true);
expect(
(await lstat(path.join(fixture, "node_modules/left"))).isSymbolicLink(),
).toBe(true);
} finally {
await rm(source, { recursive: true, force: true });
await rm(fixture, { recursive: true, force: true });
}
});
});
/**
* F-4. pnpm 11 verifies the install before it runs a script and, finding the
* fixture's copied state unfamiliar, installs. `.pnpm` and `.bin` are
* directory links into the repository's own node_modules, so that install
* rewrote the shared `.pnpm/lock.yaml` and bin shims. A fixture launched
* through `pnpm <script>` inherited `pnpm_config_verify_deps_before_run=false`
* from pnpm and was safe; the same fixture started directly
* (`node scripts/run-vitest.ts run <file>`) was not.
*/
describe("pnpm inside a linked fixture (F-4)", { timeout: childProcessTimeout(94) }, () => {
const scratch: string[] = [];
afterEach(async () => {
await Promise.all(
scratch.splice(0).map((root) => rm(root, { recursive: true, force: true })),
);
});
/** A tiny installed workspace standing in for the repository, offline. */
async function installedSource() {
const root = await mkdtemp(path.join(tmpdir(), "fixture-pnpm-"));
scratch.push(root);
const tool = path.join(root, "tool");
const source = path.join(root, "source");
await mkdir(tool, { recursive: true });
await mkdir(source, { recursive: true });
await writeFile(
path.join(tool, "package.json"),
JSON.stringify({ name: "tool", version: "1.0.0", bin: { tool: "cli.js" } }),
);
await writeFile(path.join(tool, "cli.js"), "#!/usr/bin/env node\n");
await writeFile(
path.join(source, "package.json"),
JSON.stringify({
name: "fixture-source",
version: "1.0.0",
private: true,
packageManager: "pnpm@11.17.0",
scripts: { hello: "echo hello-from-fixture" },
dependencies: { tool: "file:../tool" },
}),
);
await writeFile(path.join(source, "pnpm-workspace.yaml"), "allowBuilds: {}\n");
const environment: NodeJS.ProcessEnv = {
...pnpmFreeEnvironment(),
pnpm_config_store_dir: path.join(root, "store"),
};
// Installed on a developer machine (no CI); the fixtures then run pnpm
// with CI=true, which pnpm reads as different settings and reinstalls.
// pnpm also takes GITEA_ACTIONS, GITHUB_ACTIONS and other vendor
// variables for CI, so a runner job without CI still looked like CI and
// nothing was reinstalled. CI=false makes pnpm skip those checks.
const developer: NodeJS.ProcessEnv = { ...environment, CI: "false" };
const install = spawnSync("corepack", ["pnpm", "install", "--offline"], {
cwd: source,
encoding: "utf8",
env: developer,
});
expect(install.status, install.stdout + install.stderr).toBe(0);
return { root, source, environment };
}
// The test runner itself may run under pnpm, which exports the setting.
function pnpmFreeEnvironment(): NodeJS.ProcessEnv {
const environment: NodeJS.ProcessEnv = { ...process.env, CI: "true" };
delete environment.pnpm_config_verify_deps_before_run;
return environment;
}
async function sharedState(source: string) {
const lock = await stat(path.join(source, "node_modules/.pnpm/lock.yaml"));
const bin = await stat(path.join(source, "node_modules/.bin/tool"));
return [lock.mtimeMs, lock.ino, bin.mtimeMs, bin.ino];
}
async function runInFixture(
root: string,
source: string,
environment: NodeJS.ProcessEnv,
) {
const fixture = path.join(root, `fixture-${scratch.length}-${Date.now()}`);
await mkdir(fixture);
for (const file of selectRepositoryPaths("package-manifest")) {
await copyFile(path.join(source, file), path.join(fixture, file));
}
await linkFixtureNodeModules(fixture, source);
const before = await sharedState(source);
const result = spawnSync("corepack", ["pnpm", "hello"], {
cwd: fixture,
encoding: "utf8",
env: environment,
});
return { result, changed: (await sharedState(source)).join() !== before.join() };
}
it("installs through the linked directories unless told not to", async () => {
const { root, source, environment } = await installedSource();
// The hazard: the default re-verification installs into the shared tree.
expect((await runInFixture(root, source, environment)).changed).toBe(true);
const guarded = await runInFixture(root, source, {
...environment,
...FIXTURE_PNPM_ENVIRONMENT,
});
expect(guarded.result.status, guarded.result.stderr).toBe(0);
expect(guarded.result.stdout).toContain("hello-from-fixture");
expect(guarded.changed).toBe(false);
}, childProcessTimeout(9_876));
it("is used by every fixture that links node_modules and runs pnpm", async () => {
const listed = spawnSync(
"git",
["grep", "-l", "linkFixtureNodeModules(", "--", ...selectRepositoryPaths("fixture-code")],
{ encoding: "utf8" },
);
expect(listed.status, listed.stderr).toBe(0);
const offenders: string[] = [];
for (const file of listed.stdout.trim().split("\n")) {
if (file === "scripts/lib/fixture-node-modules.ts") continue;
if (file === "tests/unit/fixture-node-modules.test.ts") continue;
const source = await readFile(file, "utf8");
const runsPnpm = /\["pnpm"|\[pnpmCli\b/u.test(source);
if (runsPnpm && !source.includes("FIXTURE_PNPM_ENVIRONMENT")) offenders.push(file);
}
expect(offenders).toEqual([]);
});
// Runner run 291. A fixture that runs scripts/run-ci-gate.ts with the PR
// run's job environment read the fixture root's missing path table. Every
// such fixture starts the gate with the fixture environment.
it("is used by every fixture that runs scripts/run-ci-gate.ts", async () => {
const listed = spawnSync(
"git",
["grep", "-l", "-F", 'resolve("scripts/run-ci-gate.ts")', "--", ...selectRepositoryPaths("fixture-code")],
{ encoding: "utf8" },
);
expect(listed.status, listed.stderr).toBe(0);
const files = listed.stdout.trim().split("\n").filter((file) => file !== "tests/unit/fixture-node-modules.test.ts");
expect(files.length).toBeGreaterThan(0);
const offenders: string[] = [];
for (const file of files) {
if (!(await readFile(file, "utf8")).includes("FIXTURE_PNPM_ENVIRONMENT")) offenders.push(file);
}
expect(offenders).toEqual([]);
});
});