Files
clean-architecture-frontend…/tests/unit/template-probe-features.test.ts
DongHyeonka 4ab35c4a05
frontend-quality-gates / merge / static checks (pull_request) Successful in 2m50s
frontend-quality-gates / merge / tests (pull_request) Failing after 14m15s
frontend-quality-gates / merge / browser tests (pull_request) Successful in 10m29s
frontend-quality-gates / FE-GATE-017 / diagram-review (pull_request) Skipped
frontend-quality-gates / FE-GATE-014 / config-compatibility (pull_request) Skipped
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (pull_request) Skipped
frontend-quality-gates / FE-GATE-026 / lab-performance (pull_request) Skipped
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (pull_request) Skipped
frontend-quality-gates / external-vulnerability-provider (pull_request) Skipped
frontend-quality-gates / external-provenance-provider (pull_request) Skipped
frontend-quality-gates / promote-verified-immutable-candidate (pull_request) Skipped
frontend-quality-gates / deploy-promoted-release (pull_request) Skipped
frontend-quality-gates / FE-GATE-019 / hosting-header (pull_request) Skipped
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (pull_request) Skipped
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (pull_request) Skipped
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (pull_request) Skipped
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (pull_request) Skipped
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (pull_request) Skipped
frontend-quality-gates / FE-GATE-018 / field-web-vitals (pull_request) Skipped
frontend-quality-gates / main / checker self-tests (pull_request) Skipped
fix(test): 템플릿 시험이 사본에 만드는 기능 ID를 예약 접두어로 옮긴다
템플릿 시험과 드릴이 저장소 사본에 고정 ID로 기능을 만든다. 매뉴얼
코드 조각 시험은 매뉴얼 예시 invoice-feature를(FE-GATE-005), 생성 기능
e2e·청크 복구·부팅 실패 spec은 order-feature를(FE-GATE-008), scaffold
드릴은 scaffold-feature를(FE-GATE-020) 쓴다. 사본에는 제품 기능이 들어
있고 create:feature는 같은 ID나 같은 접두어를 거부한다. 그래서 매뉴얼
1단계 예시대로 invoice-feature를 만든 제품은 기능 코드와 상관없이 merge
게이트에서 막힌다.

고른 방법: 사본에 만드는 기능 ID를 모두 이미 정한 예약 접두어
typecheck-probe-로 옮기고 scripts/lib/template-probe-features.ts 한 곳에
둔다. 매뉴얼 조각은 invoice-feature 기준 그대로 두고, 시험이 조각과
검사 파일의 이름(INVOICE_, Invoice, invoice-, invoice)을 예약 기능의
이름으로 바꿔 넣는다(renameFeatureText). 생성 기능 e2e는 메시지 키와
계약 이름을 ID에서 만든다. 버린 대안: 사본에서 제품의 같은 이름
기능을 먼저 지우기(등록·조립 파일까지 지워야 해 사본이 제품과 달라진다),
create:feature가 흔한 이름을 거부하기(제품 이름을 막는다).

위험·한계: 이름 바꾸기는 낱말 단위 치환이라 조각의 영어 문장 속
invoice도 바뀐다(조각과 검사가 함께 바뀌어 결과는 같다). 제품이
typecheck-probe-로 시작하는 기능을 만들면 다시 부딪친다. 매뉴얼과
create-feature 참조에 쓰지 말라고 적었고 생성 명령이 막지는 않는다.
measure-feature-shape-growth의 s000-feature 꼴 ID는 그대로 뒀다.

검증: desktop에서 RED(이 커밋의 시험을 기준 커밋에 얹음)와 GREEN,
제품 상태(invoice-feature·order-feature를 만든 사본)의 FE-GATE-005·008
재현은 PR 본문에 적는다.

Refs: 1112/08-02
2026-11-12 22:32:09 +09:00

110 lines
4.0 KiB
TypeScript

import { describe, expect, it } from "vitest";
import { planFeature, type InstalledFacts } from "../../scripts/create-feature.ts";
import { GENERATED_FEATURE_ID } from "../../scripts/lib/generated-feature.ts";
import {
LISTED_SAMPLE_PROBE_FEATURE_ID,
MANUAL_EXAMPLE_FEATURE_ID,
MANUAL_PROBE_FEATURE_ID,
SCAFFOLD_PROBE_FEATURE_ID,
SCAFFOLD_WRITE_PROBE_FEATURE_ID,
TEMPLATE_PROBE_PREFIX,
renameFeatureText,
} from "../../scripts/lib/template-probe-features.ts";
/**
* 1112/08-02. The template's own tests add a feature to a copy of the
* repository, and that copy holds the product's features. create:feature
* refuses an id a feature there has, or one with the same prefix, so a
* template test that used the manual's example (`invoice-feature`) or a plain
* business word (`order-feature`) failed FE-GATE-005 and FE-GATE-008 in a
* product that had built a feature by that name.
*/
const PROBE_IDS = Object.freeze([
GENERATED_FEATURE_ID,
MANUAL_PROBE_FEATURE_ID,
LISTED_SAMPLE_PROBE_FEATURE_ID,
SCAFFOLD_PROBE_FEATURE_ID,
SCAFFOLD_WRITE_PROBE_FEATURE_ID,
]);
const TOPIC_SUFFIX = "abcdefghjkmnpqrstvwxyz0123";
/** A product that built features by the names a business app would pick. */
const PRODUCT: InstalledFacts = Object.freeze({
appIds: ["template-app"],
featureIds: [
"invoice-feature",
"order-feature",
"orders-feature",
"scaffold-feature",
"listed-sample-feature",
"invoice",
"order",
],
contexts: [
{ id: "invoice-context", routePath: "invoices/*" },
{ id: "order-context", routePath: "orders/*" },
],
contextDirectories: ["invoice-context", "order-context"],
routes: [
{ routeId: "INVOICE_LIST", path: "/invoices", chunkId: "route-invoice-list", navigationOrder: 50 },
{ routeId: "ORDER_LIST", path: "/orders", chunkId: "route-order-list", navigationOrder: 60 },
],
topics: [],
messageKeys: ["invoice.list.title", "order.list.title"],
});
/** The template as it ships: no feature. */
const TEMPLATE: InstalledFacts = Object.freeze({
appIds: ["template-app"],
featureIds: [],
contexts: [],
contextDirectories: [],
routes: [],
topics: [],
messageKeys: [],
});
describe("feature ids the template's tests create in a copy", () => {
it("all begin with the reserved probe prefix", () => {
for (const id of PROBE_IDS) expect(id.startsWith(TEMPLATE_PROBE_PREFIX), id).toBe(true);
expect(new Set(PROBE_IDS).size).toBe(PROBE_IDS.length);
});
it("are accepted in a product that built features by business names", () => {
for (const id of PROBE_IDS) {
expect(() => planFeature({ id, write: "KEYED" }, PRODUCT, () => TOPIC_SUFFIX), id).not.toThrow();
}
});
});
describe("renameFeatureText", () => {
it("moves every spelling of the manual's example to the probe's", () => {
const text = [
"src/features/invoice-feature/presentation/use-invoice-list-filters.ts",
"INVOICE_LIST INVOICE_CREATE_EFFECT InvoiceProblem useInvoiceListFilters",
"invoiceListSearchSchema invoice.list.title /invoices invoice-create-v1",
].join("\n");
expect(renameFeatureText(text, MANUAL_EXAMPLE_FEATURE_ID, MANUAL_PROBE_FEATURE_ID)).toBe(
[
"src/features/typecheck-probe-invoice-feature/presentation/use-typecheck-probe-invoice-list-filters.ts",
"TYPECHECK_PROBE_INVOICE_LIST TYPECHECK_PROBE_INVOICE_CREATE_EFFECT TypecheckProbeInvoiceProblem useTypecheckProbeInvoiceListFilters",
"typecheckProbeInvoiceListSearchSchema typecheckProbeInvoice.list.title /typecheckProbeInvoices typecheck-probe-invoice-create-v1",
].join("\n"),
);
});
it("gives the names create:feature writes for the probe", () => {
const manual = planFeature({ id: MANUAL_EXAMPLE_FEATURE_ID, write: "NEVER" }, TEMPLATE, () => TOPIC_SUFFIX);
const probe = planFeature({ id: MANUAL_PROBE_FEATURE_ID, write: "NEVER" }, TEMPLATE, () => TOPIC_SUFFIX);
expect(
[...manual.files.keys()].map((file) =>
renameFeatureText(file, MANUAL_EXAMPLE_FEATURE_ID, MANUAL_PROBE_FEATURE_ID),
),
).toEqual([...probe.files.keys()]);
});
});