The provider sandbox never ran. bubblewrap 0.9.0 stops parsing an `--args` file at the first non-option and never hands the remainder back, so the command written into that file was silently dropped: bwrap printed its usage text, exited 1, and the provider produced no evidence at all. The options still travel in the args file — that is what keeps host paths and credentials out of `/proc/<pid>/cmdline` — but the command now rides on real argv, and `encodeProviderBwrapInput` refuses a `--` so the drop cannot come back. The scope wrapper then could not exit. It read the supervisor's liveness pipe through `fs`, which runs a blocking `read(2)` on a threadpool thread; the supervisor holds that pipe open for the scope's whole life, so the read never returned and closing the descriptor did not interrupt it. Once bubblewrap finished the wrapper deadlocked in `process.exit`, the scope outlived the provider, and a completed run was reported as a timeout kill. The channel is now read through the event loop, so teardown is observable and terminal. Creation modes were left to the ambient umask. `mkdir(mode)` and `open(mode)` are requests the kernel subtracts the umask from, so a runner exporting a restrictive umask produced directories it could not enter and handed `tar` a file it could not re-open. Private modes are pinned instead of inherited. Promotion cleanup deleted before it checked. Removals run through a pinned descriptor, so a leaf substituted after validation had this promotion's exact five destroyed first and the substitution reported afterwards, leaving a half-emptied directory a retry could not tell from a completed one. The name is re-bound to the inode before anything is removed, so the failure is total. Separately, release coherence proved the artifacts agreed with each other but never that they belonged where they were going: a build whose runtime document said `APP_ENV: local`, `AUTH_MODE: demo` and a loopback API is coherent with itself and passed every gate. `public/` is copied verbatim into `dist/`, so that local document shipped with every build regardless of what the build was for. Runtime configuration now comes from a declared profile, and FE-GATE-027 refuses to admit an artifact to an environment it does not match — including refusing an undeclared destination, so nothing is admitted by omission. `REQUEST_TIMEOUT_MS` and `VITE_ROUTER_BASE_PATH` were validated and then dropped: the V3 executor ran every operation on its contract's own deadline, and Vite emitted root-absolute assets for a sub-path deployment. The timeout is now a ceiling that may tighten a contract but never loosen one, and one base path feeds the router, the Service Worker scope and the asset base together. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
210 lines
7.3 KiB
TypeScript
210 lines
7.3 KiB
TypeScript
export type ProviderKind = "vulnerability" | "provenance";
|
|
|
|
const MEMORY_MAX = 1_073_741_824;
|
|
const TASKS_MAX = 64;
|
|
const STOP_TIMEOUT_MS = 5_000;
|
|
const RUNTIME_GRACE_MS = 10_000;
|
|
const UNIT_NAME = /^ca-provider-(?:vulnerability|provenance)-[1-9][0-9]*-[0-9a-f]{24}\.scope$/u;
|
|
const UNIT_NONCE = /^[0-9a-f]{24}$/u;
|
|
const ENVIRONMENT_NAME = /^[A-Za-z_][A-Za-z0-9_]*$/u;
|
|
const ENFORCEMENT_GATE = [
|
|
'cgroup_path=""',
|
|
"while IFS=: read -r hierarchy controllers candidate; do",
|
|
' if [ "$hierarchy" = 0 ] && [ -z "$controllers" ]; then cgroup_path=$candidate; fi',
|
|
"done < /proc/self/cgroup",
|
|
'if [ -z "$cgroup_path" ]; then',
|
|
" printf '%s\\n' 'provider cgroup enforcement failed: unified cgroup v2 membership is required' >&2",
|
|
" exit 125",
|
|
"fi",
|
|
'case "$cgroup_path" in',
|
|
' */"$0") ;;',
|
|
" *)",
|
|
" printf '%s\\n' 'provider cgroup enforcement failed: unit membership is invalid' >&2",
|
|
" exit 125",
|
|
" ;;",
|
|
"esac",
|
|
"cgroup_root=/sys/fs/cgroup$cgroup_path",
|
|
"require_cgroup_value() {",
|
|
' actual=$(/bin/cat "$cgroup_root/$1") || {',
|
|
" printf 'provider cgroup enforcement failed: cannot read %s\\n' \"$1\" >&2",
|
|
" exit 125",
|
|
" }",
|
|
' if [ "$actual" != "$2" ]; then',
|
|
" printf 'provider cgroup enforcement failed: %s is %s, expected %s\\n' \"$1\" \"$actual\" \"$2\" >&2",
|
|
" exit 125",
|
|
" fi",
|
|
"}",
|
|
`require_cgroup_value memory.max ${MEMORY_MAX}`,
|
|
"require_cgroup_value memory.swap.max 0",
|
|
`require_cgroup_value pids.max ${TASKS_MAX}`,
|
|
"require_cgroup_value cpu.max '100000 100000'",
|
|
'exec "$@"',
|
|
].join("\n");
|
|
|
|
export function formatProviderCgroupUnitName(
|
|
kind: ProviderKind,
|
|
supervisorPid: number,
|
|
nonce: string,
|
|
): string {
|
|
if (!Number.isSafeInteger(supervisorPid) || supervisorPid <= 0 || !UNIT_NONCE.test(nonce)) {
|
|
throw new TypeError("provider cgroup unit identity is invalid");
|
|
}
|
|
const unit = `ca-provider-${kind}-${supervisorPid}-${nonce}.scope`;
|
|
assertUnit(unit);
|
|
return unit;
|
|
}
|
|
|
|
export function systemdRunProviderArguments(
|
|
unit: string,
|
|
timeoutMs: number,
|
|
cpuSeconds: number,
|
|
nodeExecutable: string,
|
|
wrapperScript: string,
|
|
reportPath: string,
|
|
reportDev: number,
|
|
reportIno: number,
|
|
): string[] {
|
|
assertUnit(unit);
|
|
if (!Number.isSafeInteger(timeoutMs) || timeoutMs <= 0 || timeoutMs > Number.MAX_SAFE_INTEGER - RUNTIME_GRACE_MS) {
|
|
throw new TypeError("provider cgroup runtime is invalid");
|
|
}
|
|
if (!Number.isSafeInteger(cpuSeconds) || cpuSeconds <= 0) {
|
|
throw new TypeError("provider cgroup CPU limit is invalid");
|
|
}
|
|
if (
|
|
!nodeExecutable.startsWith("/") || !wrapperScript.startsWith("/") ||
|
|
!reportPath.startsWith("/") || reportPath.includes("\0") ||
|
|
!Number.isSafeInteger(reportDev) || reportDev <= 0 ||
|
|
!Number.isSafeInteger(reportIno) || reportIno <= 0
|
|
) {
|
|
throw new TypeError("provider scope wrapper path is invalid");
|
|
}
|
|
return [
|
|
"--user",
|
|
"--scope",
|
|
"--collect",
|
|
"--quiet",
|
|
"--expand-environment=no",
|
|
`--unit=${unit}`,
|
|
`--property=MemoryMax=${MEMORY_MAX}`,
|
|
"--property=MemorySwapMax=0",
|
|
`--property=TasksMax=${TASKS_MAX}`,
|
|
"--property=CPUQuota=100%",
|
|
"--property=CPUQuotaPeriodSec=100ms",
|
|
"--property=KillMode=control-group",
|
|
"--property=SendSIGKILL=yes",
|
|
`--property=TimeoutStopSec=${STOP_TIMEOUT_MS}ms`,
|
|
`--property=RuntimeMaxSec=${timeoutMs + RUNTIME_GRACE_MS}ms`,
|
|
"--",
|
|
"/bin/sh",
|
|
"-eu",
|
|
"-c",
|
|
ENFORCEMENT_GATE,
|
|
unit,
|
|
nodeExecutable,
|
|
wrapperScript,
|
|
String(cpuSeconds),
|
|
reportPath,
|
|
String(reportDev),
|
|
String(reportIno),
|
|
];
|
|
}
|
|
|
|
export type ProviderScopeFrame = Readonly<{
|
|
bwrapInput: Buffer;
|
|
/**
|
|
* The sandboxed command, kept out of the args file on purpose.
|
|
*
|
|
* `bwrap --args FD` splices the file's options into the option stream, but
|
|
* bubblewrap stops at the first non-option and never propagates the command
|
|
* back out of the recursive parse. A command written into the args file is
|
|
* therefore silently dropped and bubblewrap exits with its usage text, so
|
|
* the sandbox is never entered and the provider produces no evidence at all.
|
|
* Only the options may be hidden; the command travels on real argv.
|
|
*
|
|
* Nothing secret lives here: credentials and the provider command reach the
|
|
* sandbox through `--setenv` inside the args file, and this vector only ever
|
|
* names `prlimit` and a shell that expands `$PROVIDER_COMMAND`.
|
|
*/
|
|
bwrapCommand: readonly string[];
|
|
reportPath: string;
|
|
reportDev: number;
|
|
reportIno: number;
|
|
}>;
|
|
|
|
export function encodeProviderScopeFrame(input: ProviderScopeFrame): Buffer {
|
|
if (
|
|
!Buffer.isBuffer(input.bwrapInput) || input.bwrapInput.byteLength === 0 ||
|
|
!input.reportPath.startsWith("/") || input.reportPath.includes("\0") ||
|
|
!Number.isSafeInteger(input.reportDev) || input.reportDev <= 0 ||
|
|
!Number.isSafeInteger(input.reportIno) || input.reportIno <= 0
|
|
) {
|
|
throw new TypeError("provider scope frame is invalid");
|
|
}
|
|
assertBwrapCommand(input.bwrapCommand);
|
|
const payload = Buffer.from(JSON.stringify({
|
|
bwrapInputBase64: input.bwrapInput.toString("base64"),
|
|
bwrapCommand: [...input.bwrapCommand],
|
|
reportPath: input.reportPath,
|
|
reportDev: input.reportDev,
|
|
reportIno: input.reportIno,
|
|
}));
|
|
const frame = Buffer.allocUnsafe(4 + payload.byteLength);
|
|
frame.writeUInt32BE(payload.byteLength, 0);
|
|
payload.copy(frame, 4);
|
|
return frame;
|
|
}
|
|
|
|
/**
|
|
* The command vector bubblewrap will exec. It has to be an absolute executable
|
|
* so the sandbox never resolves it through a `PATH` the caller controls.
|
|
*/
|
|
export function assertBwrapCommand(command: readonly string[]): void {
|
|
if (
|
|
!Array.isArray(command) || command.length === 0 ||
|
|
typeof command[0] !== "string" || !command[0].startsWith("/") ||
|
|
command.some((argument) =>
|
|
typeof argument !== "string" || argument.includes("\0"),
|
|
)
|
|
) {
|
|
throw new TypeError("provider bwrap command is invalid");
|
|
}
|
|
}
|
|
|
|
export function encodeProviderBwrapInput(
|
|
optionArguments: readonly string[],
|
|
environment: Readonly<Record<string, string | undefined>>,
|
|
): Buffer {
|
|
if (optionArguments.some((argument) => argument.includes("\0"))) {
|
|
throw new TypeError("provider bwrap argument is invalid");
|
|
}
|
|
// A bare `--` ends bubblewrap's option stream. Inside an args file that also
|
|
// ends the recursive parse, so everything after it is discarded rather than
|
|
// executed. Refusing it here keeps the drop from being reintroduced by a
|
|
// caller that appends a command to the option list.
|
|
if (optionArguments.includes("--")) {
|
|
throw new TypeError("provider bwrap options may not terminate the option stream");
|
|
}
|
|
const entries = Object.entries(environment).sort(([left], [right]) =>
|
|
left < right ? -1 : left > right ? 1 : 0,
|
|
);
|
|
if (entries.some(([name, value]) =>
|
|
!ENVIRONMENT_NAME.test(name) || value === undefined || value.includes("\0")
|
|
)) {
|
|
throw new TypeError("provider bwrap environment is invalid");
|
|
}
|
|
const input = ["--clearenv"];
|
|
for (const [name, value] of entries) input.push("--setenv", name, value ?? "");
|
|
input.push(...optionArguments);
|
|
return Buffer.from(`${input.join("\0")}\0`);
|
|
}
|
|
|
|
export function systemctlKillProviderArguments(unit: string): string[] {
|
|
assertUnit(unit);
|
|
return ["--user", "kill", "--kill-whom=all", "--signal=SIGKILL", unit];
|
|
}
|
|
|
|
function assertUnit(unit: string): void {
|
|
if (!UNIT_NAME.test(unit)) throw new TypeError("provider cgroup unit name is invalid");
|
|
}
|