- cursor pagination re-serialized every accumulated item on each page
(O(pages x total)) and used items.push(...page.items), which throws
RangeError for a large page, so loadAll rejected instead of returning
a Result. Each page is now measured once and summed (errs high by at
most one byte per page), the item count is checked before copying,
and items are appended one by one.
- conditional-validator-store accepted `W/"` as a weak ETag because its
opening quote also satisfied endsWith('"'). The closing quote must now
come after the opening one.
- browser-rpc-runtime's validTransportFailure had no callers, duplicated
decodeTransportFailure and read properties directly, which RPC-RR-04
forbids. Deleted (approved for this template).
Verified: new tests failed RED (18 serialized items instead of 6 because
the accumulated array was passed each time, RangeError for a 1,000,000
item page, `W/"` installed) and pass now. All lane gates pass except the
known removal-fixture test.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
94 lines
3.1 KiB
TypeScript
94 lines
3.1 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
|
|
import { createConditionalValidatorStore } from "../../src/adapters/query-cache/conditional-validator-store.ts";
|
|
import { createRuntimeIdentityRegistry } from "../../src/contracts/query-keys.ts";
|
|
|
|
function scope() {
|
|
let current = true;
|
|
const lifetime = new AbortController();
|
|
return {
|
|
snapshot: {
|
|
generation: 3,
|
|
fingerprint: "scope-token-00000003",
|
|
identities: createRuntimeIdentityRegistry({
|
|
tokenFactory: () => crypto.randomUUID(),
|
|
}),
|
|
signal: lifetime.signal,
|
|
isCurrent: () => current,
|
|
},
|
|
expire: () => {
|
|
current = false;
|
|
lifetime.abort();
|
|
},
|
|
};
|
|
}
|
|
|
|
describe("conditional validator CAS sidecar", () => {
|
|
it("accepts 304 only for the exact scope, representation and cache revision", () => {
|
|
const selectedScope = scope();
|
|
const binding = {
|
|
definitionId: "resource-detail-v1",
|
|
identityToken: "identity-token-00000001",
|
|
representationVersion: 1,
|
|
scope: selectedScope.snapshot,
|
|
};
|
|
const store = createConditionalValidatorStore();
|
|
expect(store.install(binding, '"etag-a"', 7)).toBe(true);
|
|
expect(store.prepare(binding, 7)).toBe('"etag-a"');
|
|
expect(store.acceptNotModified(binding, 7, true)).toBe(true);
|
|
expect(store.acceptNotModified(binding, 8, true)).toBe(false);
|
|
expect(store.acceptNotModified(binding, 7, false)).toBe(false);
|
|
|
|
selectedScope.expire();
|
|
expect(store.prepare(binding, 7)).toBeNull();
|
|
expect(store.acceptNotModified(binding, 7, true)).toBe(false);
|
|
});
|
|
|
|
it("keeps colon-bearing validator tuples injective", () => {
|
|
const selectedScope = scope();
|
|
// N-05. Both bindings are individually valid and, under a delimiter join,
|
|
// encode to the same key.
|
|
const first = {
|
|
definitionId: "resource:detail",
|
|
identityToken: "identity-token-00000001",
|
|
representationVersion: 1,
|
|
scope: selectedScope.snapshot,
|
|
};
|
|
const second = {
|
|
definitionId: "resource",
|
|
identityToken: "detail:identity-token-00000001",
|
|
representationVersion: 1,
|
|
scope: selectedScope.snapshot,
|
|
};
|
|
const store = createConditionalValidatorStore();
|
|
|
|
expect(store.install(first, '"etag-a"', 7)).toBe(true);
|
|
expect(store.install(second, '"etag-b"', 7)).toBe(true);
|
|
|
|
expect(store.prepare(first, 7)).toBe('"etag-a"');
|
|
expect(store.prepare(second, 7)).toBe('"etag-b"');
|
|
});
|
|
|
|
it("rejects malformed validators and bounded-capacity overflow", () => {
|
|
const firstScope = scope();
|
|
const store = createConditionalValidatorStore(1);
|
|
const first = {
|
|
definitionId: "resource-detail-v1",
|
|
identityToken: "identity-token-00000001",
|
|
representationVersion: 1,
|
|
scope: firstScope.snapshot,
|
|
};
|
|
expect(store.install(first, "raw-etag", 1)).toBe(false);
|
|
// Q-6.3-12. The opening quote of `W/"` is not also its closing quote.
|
|
expect(store.install(first, 'W/"', 1)).toBe(false);
|
|
expect(store.install(first, 'W/"etag-a"', 1)).toBe(true);
|
|
expect(
|
|
store.install(
|
|
{ ...first, identityToken: "identity-token-00000002" },
|
|
'"etag-b"',
|
|
1,
|
|
),
|
|
).toBe(false);
|
|
});
|
|
});
|