frontend-quality-gates / merge / tests (pull_request) Canceled after 0s
frontend-quality-gates / merge / browser tests (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-014 / config-compatibility (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-026 / lab-performance (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (pull_request) Canceled after 0s
frontend-quality-gates / external-vulnerability-provider (pull_request) Canceled after 0s
frontend-quality-gates / external-provenance-provider (pull_request) Canceled after 0s
frontend-quality-gates / promote-verified-immutable-candidate (pull_request) Canceled after 0s
frontend-quality-gates / deploy-promoted-release (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-019 / hosting-header (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-018 / field-web-vitals (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-017 / diagram-review (pull_request) Canceled after 0s
frontend-quality-gates / main / checker self-tests (pull_request) Canceled after 0s
frontend-quality-gates / merge / static checks (pull_request) Canceled after 51s
앞 커밋 뒤 확인 리뷰가 셋을 찾았다. - 같은 지시어가 두 번이면 검사는 뒤 값을, 브라우저는 앞 값을 쓴다(CSP3). 키워드도 대소문자를 가려 비교한다. 그래서 `script-src 'self' 'unsafe-inline'; script-src 'self'`와 `'Unsafe-Inline'`이 통과한다. - 0929/13-04 완료 기준 「CSP를 바꿀 때 한 파일만 고친다」가 안 됐다. hosting fixture가 선언한 보안 header 일곱을 표면 넷에 그대로 복사한다. - check:browser-security가 검사를 부르는 연결을 지키는 시험이 없다. 고른 방법: 지시어는 첫 것만, 이름과 키워드는 소문자로 읽는다. 선언 문서를 읽는 declaredCspProblems를 두고 check:browser-security가 그것을 부른다. check:security:fixtures(FE-GATE-029)가 거절 fixture(대소문자를 바꾼 'unsafe-inline'이 앞 script-src에 있음)를 거절하고 선언을 받는지 본다. hosting fixture에서 보안 header를 지우고, verify-hosting-headers의 fixture 모드는 보안 header가 필요한 표면에 선언을 답으로 채운다. fixture가 적은 값은 그대로 host의 답으로 비교한다. 버린 대안: fixture를 선언에서 생성하는 스크립트(생성물이 하나 더 생기고 대조할 것은 같다). 위험·한계: fixture 모드의 보안 header 비교는 선언끼리의 비교가 된다. 전에도 fixture 모드는 UNVERIFIED였다(live 모드만 host를 본다). 검증: csp-policy.test.ts 새 시험(브라우저처럼 읽기 다섯, 뒤 지시어 무시, declaredCspProblems 넷)과 hosting-probe.test.ts 새 시험 둘(선언만 바꾼 뒤 fixture 통과, fixture가 적은 header는 비교)을 고치기 전 코드에서 RED로 보고 desktop에서 GREEN·FE-GATE-029를 돌린다(PR 본문). Refs: 0929/13-04
195 lines
6.3 KiB
TypeScript
195 lines
6.3 KiB
TypeScript
import { spawnSync } from "node:child_process";
|
|
import { mkdtemp, readFile, rm } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
|
|
import { declaredCspProblems } from "./csp-policy.ts";
|
|
|
|
type ScanResult = Readonly<{
|
|
error?: Error;
|
|
status: number | null;
|
|
signal: NodeJS.Signals | null;
|
|
stdout: string;
|
|
stderr: string;
|
|
}>;
|
|
|
|
type SecurityFixtureCheckDependencies = Readonly<{
|
|
createTempDirectory?: () => Promise<string>;
|
|
runScan?: (artifactPath: string, policyPath: string) => ScanResult;
|
|
readArtifact?: (artifactPath: string) => Promise<string>;
|
|
cleanup?: (directory: string) => Promise<void>;
|
|
}>;
|
|
|
|
type Document = Record<string, unknown>;
|
|
|
|
function record(value: unknown, label: string): Document {
|
|
if (!value || typeof value !== "object" || Array.isArray(value)) {
|
|
throw new TypeError(`${label} must be an object`);
|
|
}
|
|
return value as Document;
|
|
}
|
|
|
|
function defaultScan(artifactPath: string, policyPath: string): ScanResult {
|
|
const scan = spawnSync(
|
|
"node",
|
|
[
|
|
"scripts/security-scan.ts",
|
|
"--policy",
|
|
policyPath,
|
|
"--artifact",
|
|
artifactPath,
|
|
],
|
|
{ encoding: "utf8" },
|
|
);
|
|
return {
|
|
...(scan.error ? { error: scan.error } : {}),
|
|
status: scan.status,
|
|
signal: scan.signal,
|
|
stdout: scan.stdout ?? "",
|
|
stderr: scan.stderr ?? "",
|
|
};
|
|
}
|
|
|
|
function assertExactFindings(rawArtifact: string): void {
|
|
const sarif = record(JSON.parse(rawArtifact), "security fixture SARIF");
|
|
const runs = Array.isArray(sarif.runs) ? sarif.runs : [];
|
|
const run = record(runs[0], "security fixture SARIF run");
|
|
const results = Array.isArray(run.results) ? run.results : [];
|
|
const actual = results
|
|
.map((rawResult) => {
|
|
const result = record(rawResult, "security fixture result");
|
|
const locations = Array.isArray(result.locations) ? result.locations : [];
|
|
const location = record(locations[0], "security fixture location");
|
|
const physical = record(
|
|
location.physicalLocation,
|
|
"security fixture physical location",
|
|
);
|
|
const artifactLocation = record(
|
|
physical.artifactLocation,
|
|
"security fixture artifact location",
|
|
);
|
|
return `${String(artifactLocation.uri)}:${String(result.ruleId)}`;
|
|
})
|
|
.sort();
|
|
const root = "tests/fixtures/security/secret-detection/forbidden";
|
|
const expected = [
|
|
`${root}/config.json:assigned-secret`,
|
|
`${root}/dist.ts:assigned-secret`,
|
|
`${root}/source.ts:aws-access-key`,
|
|
].sort();
|
|
if (JSON.stringify(actual) !== JSON.stringify(expected)) {
|
|
throw new Error(
|
|
`security fixture findings mismatch: expected ${expected.join(", ")}; received ${actual.join(", ")}`,
|
|
);
|
|
}
|
|
}
|
|
|
|
export async function checkSecurityFixtures(
|
|
dependencies: SecurityFixtureCheckDependencies = {},
|
|
): Promise<void> {
|
|
const createTempDirectory =
|
|
dependencies.createTempDirectory ??
|
|
(() => mkdtemp(path.join(tmpdir(), "ca-security-fixture-")));
|
|
const runScan = dependencies.runScan ?? defaultScan;
|
|
const readArtifact = dependencies.readArtifact ?? ((target) => readFile(target, "utf8"));
|
|
const cleanup =
|
|
dependencies.cleanup ??
|
|
((directory) => rm(directory, { recursive: true, force: true }));
|
|
const directory = await createTempDirectory();
|
|
const artifactPath = path.join(directory, "scan-fixture.sarif");
|
|
try {
|
|
const scan = runScan(
|
|
artifactPath,
|
|
"tests/fixtures/security/secret-detection/forbidden-policy.json",
|
|
);
|
|
const expectedDiagnostic = "Security scan found 3 blocking result(s).";
|
|
if (
|
|
scan.error ||
|
|
scan.status !== 1 ||
|
|
scan.signal !== null ||
|
|
scan.stderr !== `${expectedDiagnostic}\n`
|
|
) {
|
|
throw new Error(
|
|
`forbidden security fixture did not fail exactly: ${scan.error?.message ?? scan.stderr}`,
|
|
);
|
|
}
|
|
assertExactFindings(await readArtifact(artifactPath));
|
|
} finally {
|
|
await cleanup(directory);
|
|
}
|
|
}
|
|
|
|
export async function checkNonmatchingSecurityIncludeFixture(
|
|
dependencies: SecurityFixtureCheckDependencies = {},
|
|
): Promise<void> {
|
|
const createTempDirectory =
|
|
dependencies.createTempDirectory ??
|
|
(() => mkdtemp(path.join(tmpdir(), "ca-security-include-fixture-")));
|
|
const runScan = dependencies.runScan ?? defaultScan;
|
|
const readArtifact =
|
|
dependencies.readArtifact ?? ((target) => readFile(target, "utf8"));
|
|
const cleanup =
|
|
dependencies.cleanup ??
|
|
((directory) => rm(directory, { recursive: true, force: true }));
|
|
const directory = await createTempDirectory();
|
|
const artifactPath = path.join(directory, "scan-fixture.sarif");
|
|
try {
|
|
const includedPath =
|
|
"tests/fixtures/security/secret-detection/misspelled";
|
|
const scan = runScan(
|
|
artifactPath,
|
|
"tests/fixtures/security/secret-detection/nonmatching-policy.json",
|
|
);
|
|
if (
|
|
scan.error ||
|
|
scan.status !== 1 ||
|
|
scan.signal !== null ||
|
|
!scan.stderr.includes(
|
|
`secret scan included path matches no inventory file: ${includedPath}`,
|
|
)
|
|
) {
|
|
throw new Error(
|
|
`nonmatching security include fixture did not fail closed: ${scan.error?.message ?? scan.stderr}`,
|
|
);
|
|
}
|
|
try {
|
|
await readArtifact(artifactPath);
|
|
} catch (error) {
|
|
if (
|
|
typeof error === "object" &&
|
|
error !== null &&
|
|
"code" in error &&
|
|
error.code === "ENOENT"
|
|
) {
|
|
return;
|
|
}
|
|
throw error;
|
|
}
|
|
throw new Error("nonmatching security include fixture wrote an artifact");
|
|
} finally {
|
|
await cleanup(directory);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* 0929/13-04. The policy check check:browser-security runs rejects its
|
|
* fixture (a keyword in another case, in the first of two script-src) and
|
|
* accepts the declared policy.
|
|
*/
|
|
export async function checkDeclaredCspFixtures(): Promise<void> {
|
|
const fixture = "tests/fixtures/security/csp/rejected-security-headers.json";
|
|
const rejected = declaredCspProblems(await readFile(fixture, "utf8"));
|
|
const expected = ["script-src allows 'unsafe-inline'"];
|
|
if (JSON.stringify(rejected) !== JSON.stringify(expected)) {
|
|
throw new Error(
|
|
`${fixture}: expected ${expected.join(", ")}; received ${rejected.join(", ") || "no problem"}`,
|
|
);
|
|
}
|
|
const declared = declaredCspProblems(
|
|
await readFile("config/hosting/security-headers.json", "utf8"),
|
|
);
|
|
if (declared.length > 0) {
|
|
throw new Error(`config/hosting/security-headers.json: ${declared.join("; ")}`);
|
|
}
|
|
}
|