DongHyeonkaandClaude Opus 5
711d61e73f
Which features a build contains was not a decision anybody could express. The reference feature was spread directly into the route, API, schema, codec and adapter registries, so shipping without it meant editing five files by hand and hoping nothing still referred to it — and there was no way at all to take it out of service on a running deployment. The removability gate proved the editing worked; nothing made it a choice. There is now one manifest. `VITE_PRODUCT_FEATURES` narrows it at build time and `FEATURE_OVERRIDES` in the runtime document takes an installed feature out of service without a rebuild. Every registry composes from the manifest, and a test fails if a new one forgets to. Both inputs are subtractive, and the vocabulary is what enforces it rather than a check somewhere downstream: the override enum has no `ENABLED`, and a build-time selection naming something the source tree does not declare is refused instead of ignored. A configuration document that could name a feature into existence would be a configuration document choosing which code runs. Disabling is not just hiding. Withdrawing a route from navigation would leave a typed deep link that still mounts the feature, so the router refuses it too and answers with a surface that says the deployment switched it off. The platform overview now distinguishes the three states an operator actually needs: serving, switched off, and not in this build. What this is not: an env var does not shrink the bundle. A static import cannot be undone by a value, and making the import graph itself depend on a configuration string is the thing §3.5 exists to prevent — measured, `none` changes the output by 58 bytes. Physical removal remains FE-GATE-020's job, and the code comments say so rather than implying otherwise. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
84 lines
2.9 KiB
TypeScript
84 lines
2.9 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { render, screen } from "@testing-library/react";
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
import { createAnonymousSessionAdapter } from "../../src/adapters/auth/external-session-adapter.ts";
|
|
import { ROUTE_REGISTRY } from "../../src/features/installed-feature-contracts.ts";
|
|
import { INSTALLED_PRODUCT_FEATURE_IDS } from "../../src/features/installed-product-manifest.ts";
|
|
import { ApplicationProvider } from "../../src/presentation/providers/application-provider.tsx";
|
|
import { AppRouter } from "../../src/presentation/routes/app-router.tsx";
|
|
import { createTestApplication } from "../helpers/create-test-application.ts";
|
|
import { createProductFeaturesStub } from "../helpers/runtime-capabilities-stub.ts";
|
|
|
|
/**
|
|
* §3.5. The runtime kill switch, exercised through the running app rather than
|
|
* through the resolver that computes it.
|
|
*
|
|
* Withdrawing a feature from navigation is not the same as taking it out of
|
|
* service: a typed deep link would still mount it. Both halves are asserted
|
|
* here, on the same render, so the switch cannot be half-wired.
|
|
*/
|
|
|
|
const FEATURE_ID = INSTALLED_PRODUCT_FEATURE_IDS[0]!;
|
|
const FEATURE_ROUTE = ROUTE_REGISTRY.REFERENCE_RESOURCE_LIST;
|
|
|
|
function renderAt(path: string, disabled: boolean) {
|
|
window.history.pushState({}, "", path);
|
|
return render(
|
|
<ApplicationProvider
|
|
application={createTestApplication({
|
|
session: createAnonymousSessionAdapter(),
|
|
...(disabled
|
|
? {
|
|
productFeatures: createProductFeaturesStub({
|
|
[FEATURE_ID]: "DISABLED_BY_CONFIG",
|
|
}),
|
|
}
|
|
: {}),
|
|
})}
|
|
>
|
|
<AppRouter />
|
|
</ApplicationProvider>,
|
|
);
|
|
}
|
|
|
|
describe("runtime product feature switch", () => {
|
|
it("advertises the feature's route while the feature is active", async () => {
|
|
renderAt("/", false);
|
|
expect(
|
|
await screen.findByRole("link", { name: FEATURE_ROUTE.navigationLabel! }),
|
|
).toBeTruthy();
|
|
});
|
|
|
|
it("withdraws the feature's route from navigation when it is disabled", async () => {
|
|
renderAt("/", true);
|
|
// The shell itself still renders: disabling a feature is not an outage.
|
|
expect(await screen.findByRole("navigation")).toBeTruthy();
|
|
expect(
|
|
screen.queryByRole("link", { name: FEATURE_ROUTE.navigationLabel! }),
|
|
).toBeNull();
|
|
});
|
|
|
|
it("takes the feature out of service for a direct deep link", async () => {
|
|
renderAt(FEATURE_ROUTE.path, true);
|
|
const surface = await screen.findByText(
|
|
(_, element) =>
|
|
element?.getAttribute("data-disabled-feature") === FEATURE_ID,
|
|
{},
|
|
{ timeout: 5000 },
|
|
);
|
|
expect(surface).toBeTruthy();
|
|
});
|
|
|
|
it("serves the same deep link while the feature is active", async () => {
|
|
renderAt(FEATURE_ROUTE.path, false);
|
|
expect(
|
|
screen.queryByText(
|
|
(_, element) =>
|
|
element?.getAttribute("data-disabled-feature") === FEATURE_ID,
|
|
),
|
|
).toBeNull();
|
|
});
|
|
});
|