문제
breaking 증거 조회 키는 registryId:row:field:kind뿐이고, 증거 검사는
5필드가 비었는지만 본다. 값은 diff에 있지만 증거와 비교하지 않는다. 그래서
한 번 증거를 쓴 row·field는 다음 변경도 새 증거 없이 통과한다. 실험 X3:
REFERENCE_RESOURCE_DETAIL.path를 08-13 증거가 설명하는
/examples/reference-resources/items/:resourceId가 아닌
.../entries/:resourceId로 바꿔도 check-registries가 "11 registries
PASS"였다. 공개 URL·API 경로·저장 키 같은 breaking 변경이 이행·롤백
계획 없이 지나간다.
고른 방법 (리뷰 최소 개선 (1))
- 값이 있는 breaking 변경(change.after가 있음)은 증거 행에 after가 있어야
하고, canonical JSON이 diff의 after와 같아야 한다. 없으면 "evidence
needs after", 다르면 "evidence explains after=..., the change is
after=..."로 실패한다. 키 순서·원시값 배열 순서는 기존 canonical 규칙
그대로라 차이로 보지 않는다.
- 삭제(row·registry·field 삭제)는 설명할 값이 없어 after를 요구하지 않는다.
- 현재 diff와 맞는 템플릿 증거 1건(REFERENCE_RESOURCE_DETAIL.path)에
after를 더했다. ci-quality-gates.md의 증거 안내에 after를 적었다.
- 완전한 증거를 만드는 테스트 두 곳(registry-compatibility,
registry-governance tamper 사례)에 after를 넣었다.
버린 대안
- after를 선택 필드로 두기: 없는 행은 지금처럼 모든 다음 변경을 통과시켜
X3이 그대로 남는다.
- 증거 키에 값 해시를 넣기(changeId 형식 변경): 기존 changeId 문법과
출력이 바뀌고 사람이 읽을 수 없다.
- 리뷰 (2) 현재 diff와 맞지 않는 증거 행 실패 또는 목록 출력, (3)
update:registry-baseline의 증거 정리: 실패로 할지 출력으로 할지, 오래된
14건을 지울지 이력 파일로 옮길지가 감사 기록을 다루는 결정이라 이번에
하지 않았다.
위험·한계
- 증거 파일 형식이 바뀐다. 다운스트림이 이 검사를 동기화하면 아직 diff에
남은 breaking 변경의 증거 행마다 after를 넣어야 게이트가 통과한다.
다음 릴리스 CHANGELOG [계약] 행이 필요하다(미출시 절이 없어 적지
않았다).
- 오래된 증거 행(현재 diff와 무관한 14건, 0929/07-02 수정으로 쓰이지 않게
된 VITE_BUILD_ID 포함)은 그대로 남는다. 위 (2)·(3)이 남은 일이다.
- 값이 큰 contract 필드(allowedValues 전체 등)의 증거는 그 값을 통째로
적어야 한다.
검증
- RED(수정 전): registry-compatibility.test.ts 새 사례 2건 실패
("rejects evidence written for another value", "requires the explained
value": expected [] to deeply equal [...]). X3 변이로 check-registries
"11 registries PASS".
- GREEN: 같은 X3 변이에서 check-registries 실패("evidence explains
after=\"/examples/reference-resources/items/:resourceId\", the change is
after=\"/examples/reference-resources/entries/:resourceId\""), 변이 없이
"11 registries PASS". registry-compatibility·registry-governance·
release-artifacts·second-api-feature-registries 53/53 통과.
compatibility fixtures 11 PASS. verify-documentation-readiness
PASS_SCOPED.
- 회귀: tsc node/test rc=0, 바꾼 파일 eslint rc=0.
- 미실행: check:architecture(pnpm), test:sample-removal(pnpm).
Refs: docs/reviews/2026-09-29-maturity-review/07-contracts.md
428 lines
13 KiB
TypeScript
428 lines
13 KiB
TypeScript
import { createHash } from "node:crypto";
|
|
|
|
export const COMPATIBILITY_IMPACTS = Object.freeze([
|
|
"none",
|
|
"additive",
|
|
"behavior-change",
|
|
"breaking",
|
|
] as const);
|
|
|
|
type CompatibilityImpact = (typeof COMPATIBILITY_IMPACTS)[number];
|
|
type RegistryRecord = Record<string, unknown> & {
|
|
registryId?: unknown;
|
|
contract?: unknown;
|
|
rows?: unknown;
|
|
};
|
|
type RegistryChange = {
|
|
changeId: string;
|
|
registryId: string;
|
|
rowName: string;
|
|
field: string;
|
|
kind: string;
|
|
impact: CompatibilityImpact;
|
|
before?: unknown;
|
|
after?: unknown;
|
|
};
|
|
type RegistryDiff = Readonly<{
|
|
impact: CompatibilityImpact;
|
|
changes: readonly RegistryChange[];
|
|
}>;
|
|
|
|
const impactRank = new Map(
|
|
COMPATIBILITY_IMPACTS.map((impact, index) => [impact, index]),
|
|
);
|
|
|
|
export function canonicalizeRegistryValue(value: unknown): unknown {
|
|
if (Array.isArray(value)) {
|
|
const projected: unknown[] = value.map(canonicalizeRegistryValue);
|
|
return projected.every(
|
|
(item) =>
|
|
item === null ||
|
|
["string", "number", "boolean"].includes(typeof item),
|
|
)
|
|
? projected.sort((left, right) =>
|
|
JSON.stringify(left).localeCompare(JSON.stringify(right)),
|
|
)
|
|
: projected;
|
|
}
|
|
if (value && typeof value === "object") {
|
|
return Object.fromEntries(
|
|
Object.entries(value)
|
|
.sort(([left], [right]) => left.localeCompare(right))
|
|
.map(([key, item]) => [key, canonicalizeRegistryValue(item)]),
|
|
);
|
|
}
|
|
return value;
|
|
}
|
|
|
|
export function canonicalRegistryJson(value: unknown): string {
|
|
return JSON.stringify(canonicalizeRegistryValue(value)) ?? "undefined";
|
|
}
|
|
|
|
export function registrySnapshotDigest(snapshot: unknown): string {
|
|
return createHash("sha256")
|
|
.update(canonicalRegistryJson(snapshot))
|
|
.digest("hex");
|
|
}
|
|
|
|
function strongestImpact(
|
|
current: CompatibilityImpact,
|
|
candidate: CompatibilityImpact,
|
|
): CompatibilityImpact {
|
|
return (impactRank.get(candidate) ?? 0) > (impactRank.get(current) ?? 0)
|
|
? candidate
|
|
: current;
|
|
}
|
|
|
|
function valueType(value: unknown): string {
|
|
if (value === null) return "null";
|
|
if (Array.isArray(value)) return "array";
|
|
return typeof value;
|
|
}
|
|
|
|
/** The governance `fieldTypes` vocabulary: `integer` is its own name. */
|
|
export function registryRuntimeType(value: unknown): string {
|
|
if (Number.isInteger(value)) return "integer";
|
|
return valueType(value);
|
|
}
|
|
|
|
/** `declaration` is a governance field type such as `string|null`. */
|
|
export function matchesDeclaredType(value: unknown, declaration: string): boolean {
|
|
const actual = registryRuntimeType(value);
|
|
return declaration
|
|
.split("|")
|
|
.some(
|
|
(candidate) =>
|
|
candidate === actual ||
|
|
(candidate === "number" && actual === "integer"),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* 0929/07-02. A null on one side and a value on the other is a change inside
|
|
* the field's declared type when that type admits both (`string|null`), not a
|
|
* change of type: hiding a navigation label is graded like renaming it.
|
|
*/
|
|
function isDeclaredNullableChange(
|
|
before: unknown,
|
|
after: unknown,
|
|
declaration: unknown,
|
|
): boolean {
|
|
return (
|
|
typeof declaration === "string" &&
|
|
(before === null || after === null) &&
|
|
matchesDeclaredType(before, declaration) &&
|
|
matchesDeclaredType(after, declaration)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* 0929/07-02. Every field keeps its restriction and every value it allowed:
|
|
* rows valid before stay valid. A new, dropped or narrowed restriction is
|
|
* still breaking.
|
|
*/
|
|
function onlyExtendsAllowedValues(before: unknown, after: unknown): boolean {
|
|
if (!before || !after || typeof before !== "object" || typeof after !== "object") {
|
|
return false;
|
|
}
|
|
const previous = before as Record<string, unknown>;
|
|
const current = after as Record<string, unknown>;
|
|
const fields = Object.keys(previous);
|
|
if (fields.length !== Object.keys(current).length) return false;
|
|
return fields.every((field) => {
|
|
const allowedBefore = previous[field];
|
|
const allowedAfter = current[field];
|
|
if (!Array.isArray(allowedBefore) || !Array.isArray(allowedAfter)) return false;
|
|
const kept = new Set(allowedAfter.map((value) => canonicalRegistryJson(value)));
|
|
return allowedBefore.every((value) => kept.has(canonicalRegistryJson(value)));
|
|
});
|
|
}
|
|
|
|
function changeId(
|
|
registryId: string,
|
|
rowName: string,
|
|
field: string,
|
|
kind: string,
|
|
): string {
|
|
return `${registryId}:${rowName}:${field}:${kind}`;
|
|
}
|
|
|
|
/**
|
|
* Calculates a semantic diff. Object key and primitive-array ordering is
|
|
* canonicalized before comparison and therefore cannot create a false change.
|
|
*/
|
|
export function diffRegistrySnapshots(
|
|
before: Readonly<Record<string, unknown>>,
|
|
after: Readonly<Record<string, unknown>>,
|
|
): RegistryDiff {
|
|
const changes: RegistryChange[] = [];
|
|
let impact: CompatibilityImpact = "none";
|
|
const beforeRegistryRows = (before.registries ?? []) as RegistryRecord[];
|
|
const beforeRegistries = new Map<string, RegistryRecord>(
|
|
beforeRegistryRows.map((registry) => [
|
|
String(registry.registryId),
|
|
registry,
|
|
]),
|
|
);
|
|
const afterRegistryRows = (after.registries ?? []) as RegistryRecord[];
|
|
const afterRegistries = new Map<string, RegistryRecord>(
|
|
afterRegistryRows.map((registry) => [
|
|
String(registry.registryId),
|
|
registry,
|
|
]),
|
|
);
|
|
const registryIds = new Set([
|
|
...beforeRegistries.keys(),
|
|
...afterRegistries.keys(),
|
|
]);
|
|
|
|
for (const registryId of [...registryIds].sort()) {
|
|
const previous = beforeRegistries.get(registryId);
|
|
const current = afterRegistries.get(registryId);
|
|
if (!previous || !current) {
|
|
const changeImpact = previous ? "breaking" : "additive";
|
|
impact = strongestImpact(impact, changeImpact);
|
|
changes.push({
|
|
changeId: changeId(registryId, "*", "*", previous ? "removed" : "added"),
|
|
registryId,
|
|
rowName: "*",
|
|
field: "*",
|
|
kind: previous ? "registry-removed" : "registry-added",
|
|
impact: changeImpact,
|
|
});
|
|
continue;
|
|
}
|
|
|
|
const previousContract = (previous.contract ?? {}) as Record<string, unknown>;
|
|
const currentContract = (current.contract ?? {}) as Record<string, unknown>;
|
|
const contractFields = new Set([
|
|
...Object.keys(previousContract),
|
|
...Object.keys(currentContract),
|
|
]);
|
|
for (const field of [...contractFields].sort()) {
|
|
const beforeHas = Object.hasOwn(previousContract, field);
|
|
const afterHas = Object.hasOwn(currentContract, field);
|
|
const beforeValue = previousContract[field];
|
|
const afterValue = currentContract[field];
|
|
if (
|
|
beforeHas &&
|
|
afterHas &&
|
|
canonicalRegistryJson(beforeValue) ===
|
|
canonicalRegistryJson(afterValue)
|
|
) {
|
|
continue;
|
|
}
|
|
const extendsAllowedValues =
|
|
field === "allowedValues" &&
|
|
beforeHas &&
|
|
afterHas &&
|
|
onlyExtendsAllowedValues(beforeValue, afterValue);
|
|
const kind = !beforeHas
|
|
? "contract-field-added"
|
|
: !afterHas
|
|
? "contract-field-removed"
|
|
: extendsAllowedValues
|
|
? "allowed-values-extended"
|
|
: "contract-field-changed";
|
|
const changeImpact: CompatibilityImpact = extendsAllowedValues
|
|
? "additive"
|
|
: "breaking";
|
|
impact = strongestImpact(impact, changeImpact);
|
|
changes.push({
|
|
changeId: changeId(registryId, "$contract", field, kind),
|
|
registryId,
|
|
rowName: "$contract",
|
|
field,
|
|
kind,
|
|
impact: changeImpact,
|
|
before: canonicalizeRegistryValue(beforeValue),
|
|
after: canonicalizeRegistryValue(afterValue),
|
|
});
|
|
}
|
|
|
|
const breakingFields = new Set(
|
|
(currentContract.breakingFields ?? []) as string[],
|
|
);
|
|
const fieldTypes = (currentContract.fieldTypes ?? {}) as Record<
|
|
string,
|
|
unknown
|
|
>;
|
|
const beforeRows = (previous.rows ?? {}) as Record<
|
|
string,
|
|
Record<string, unknown>
|
|
>;
|
|
const afterRows = (current.rows ?? {}) as Record<
|
|
string,
|
|
Record<string, unknown>
|
|
>;
|
|
const rowNames = new Set([
|
|
...Object.keys(beforeRows),
|
|
...Object.keys(afterRows),
|
|
]);
|
|
for (const rowName of [...rowNames].sort()) {
|
|
const beforeRow = beforeRows[rowName];
|
|
const afterRow = afterRows[rowName];
|
|
if (!beforeRow || !afterRow) {
|
|
const changeImpact = beforeRow ? "breaking" : "additive";
|
|
impact = strongestImpact(impact, changeImpact);
|
|
changes.push({
|
|
changeId: changeId(
|
|
registryId,
|
|
rowName,
|
|
"*",
|
|
beforeRow ? "removed" : "added",
|
|
),
|
|
registryId,
|
|
rowName,
|
|
field: "*",
|
|
kind: beforeRow ? "row-removed" : "row-added",
|
|
impact: changeImpact,
|
|
});
|
|
continue;
|
|
}
|
|
|
|
const fields = new Set([
|
|
...Object.keys(beforeRow),
|
|
...Object.keys(afterRow),
|
|
]);
|
|
for (const field of [...fields].sort()) {
|
|
const beforeHas = Object.hasOwn(beforeRow, field);
|
|
const afterHas = Object.hasOwn(afterRow, field);
|
|
const beforeValue = beforeRow[field];
|
|
const afterValue = afterRow[field];
|
|
if (
|
|
beforeHas &&
|
|
afterHas &&
|
|
canonicalRegistryJson(beforeValue) ===
|
|
canonicalRegistryJson(afterValue)
|
|
) {
|
|
continue;
|
|
}
|
|
let kind: string;
|
|
let changeImpact: CompatibilityImpact;
|
|
if (!beforeHas) {
|
|
kind = "field-added";
|
|
changeImpact = "additive";
|
|
} else if (!afterHas) {
|
|
kind = "field-removed";
|
|
changeImpact = "breaking";
|
|
} else if (
|
|
valueType(beforeValue) !== valueType(afterValue) &&
|
|
!isDeclaredNullableChange(beforeValue, afterValue, fieldTypes[field])
|
|
) {
|
|
kind = "field-type-changed";
|
|
changeImpact = "breaking";
|
|
} else if (
|
|
Array.isArray(beforeValue) &&
|
|
Array.isArray(afterValue) &&
|
|
beforeValue.some(
|
|
(item) =>
|
|
!afterValue.some(
|
|
(candidate) =>
|
|
canonicalRegistryJson(candidate) ===
|
|
canonicalRegistryJson(item),
|
|
),
|
|
)
|
|
) {
|
|
kind = "allowed-value-removed";
|
|
changeImpact = "breaking";
|
|
} else {
|
|
kind = "field-changed";
|
|
changeImpact = breakingFields.has(field)
|
|
? "breaking"
|
|
: "behavior-change";
|
|
}
|
|
impact = strongestImpact(impact, changeImpact);
|
|
changes.push({
|
|
changeId: changeId(registryId, rowName, field, kind),
|
|
registryId,
|
|
rowName,
|
|
field,
|
|
kind,
|
|
impact: changeImpact,
|
|
before: canonicalizeRegistryValue(beforeValue),
|
|
after: canonicalizeRegistryValue(afterValue),
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
return Object.freeze({
|
|
impact,
|
|
changes: Object.freeze(changes),
|
|
});
|
|
}
|
|
|
|
export function verifyRegistryBaselineApproval(
|
|
snapshot: Readonly<Record<string, unknown>>,
|
|
approval: Readonly<Record<string, unknown>>,
|
|
) {
|
|
const actualDigest = registrySnapshotDigest(snapshot);
|
|
const approvedDigest = approval.snapshotDigest;
|
|
return Object.freeze({
|
|
passed:
|
|
approval.schemaVersion === 1 &&
|
|
typeof approval.owner === "string" &&
|
|
approval.owner.length > 0 &&
|
|
typeof approval.approvedAt === "string" &&
|
|
approvedDigest === actualDigest,
|
|
actualDigest,
|
|
approvedDigest:
|
|
typeof approvedDigest === "string" ? approvedDigest : "missing",
|
|
});
|
|
}
|
|
|
|
export function validateBreakingEvidence(
|
|
diff: RegistryDiff,
|
|
evidenceFile: Readonly<Record<string, unknown>>,
|
|
) {
|
|
const entries = (evidenceFile.changes ?? []) as Array<Record<string, unknown>>;
|
|
const evidence = new Map<string, Record<string, unknown>>(
|
|
entries.map((entry) => [String(entry.changeId), entry]),
|
|
);
|
|
const failures: string[] = [];
|
|
for (const change of diff.changes.filter(
|
|
(entry) => entry.impact === "breaking",
|
|
)) {
|
|
const entry = evidence.get(change.changeId);
|
|
if (!entry) {
|
|
failures.push(`breaking change missing evidence: ${change.changeId}`);
|
|
continue;
|
|
}
|
|
// 0929/07-01. The changeId names a row and field, not a value. Without
|
|
// the value, evidence for one change would also pass the next change of
|
|
// the same field. Removals have no value to name.
|
|
if (change.after !== undefined) {
|
|
if (!Object.hasOwn(entry, "after")) {
|
|
failures.push(
|
|
`breaking change ${change.changeId} evidence needs after (the canonical JSON value it explains)`,
|
|
);
|
|
} else if (
|
|
canonicalRegistryJson(entry.after) !== canonicalRegistryJson(change.after)
|
|
) {
|
|
failures.push(
|
|
`breaking change ${change.changeId} evidence explains after=${canonicalRegistryJson(entry.after)}, the change is after=${canonicalRegistryJson(change.after)}`,
|
|
);
|
|
}
|
|
}
|
|
for (const field of [
|
|
"versionBump",
|
|
"migration",
|
|
"compatibilityWindow",
|
|
"rollback",
|
|
"owner",
|
|
]) {
|
|
const value = entry[field];
|
|
if (typeof value !== "string" || value.trim().length === 0) {
|
|
failures.push(
|
|
`breaking change ${change.changeId} missing non-empty ${field}`,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
return Object.freeze({
|
|
passed: failures.length === 0,
|
|
failures: Object.freeze(failures),
|
|
});
|
|
}
|