문제: 1105/12-04 뒤 빌드는 `RUN_OUTPUT_ROOT` 아래에 쓰는데, check:bundle의 두 단계(`generate-supply-chain.ts`, `check-bundle.ts`)는 이 변수를 읽지 않고 checkout의 `dist`와 `artifacts/`를 읽는다. 셸에 이 변수를 둔 채 빌드와 check:bundle을 돌리면 예산을 3,504 B 넘는 새 빌드 대신 이전 빌드를 재서 PASS한다(리뷰 12-R2). ci:gate의 신선도 검사도 bundle.json을 check:bundle이 다시 쓰므로 막지 못한다. 고른 방법: `scripts/lib/run-isolation.ts`에 `checkoutBuildReadFailure`를 두고, 두 스크립트가 무엇을 읽기 전에 부른다. 출력 루트가 `.`이 아니면 변수 값과 이유를 적고 exit 1로 멈춘다. `.`(Playwright 설정이 run ID 없이 web server에 넘기는 값)과 빈 값은 그대로 돈다. 그래서 `RUN_OUTPUT_ROOT=.tmp/x corepack pnpm ci:gate -- FE-GATE-012`도 check-bundle 단계에서 변수 이름을 적고 실패한다. 버린 대안: ci:gate가 시작 전에 거절하기(리뷰 문서 (b)). 12-R2처럼 check:bundle을 직접 돌리는 경우를 막지 못한다. 두 스크립트가 같은 루트를 읽게 하기(c)는 supply-chain 산출물 전부와 CI upload 경로를 함께 옮겨야 한다. 위험·한계: - FE-GATE-012는 빌드 단계를 끝까지 돈 뒤 check-bundle에서 실패한다. 빌드 시간만큼 늦게 알린다. - 같은 모양일 수 있는 `check:app-build-input:bundle`, `check:optional-recipes --require-dist`, release candidate 조립은 보지 않았다. FE-GATE-012에서는 check-bundle이 먼저 실패해 거기까지 가지 않는다. - 디버깅으로 변수를 둔 사람은 check:bundle 전에 지워야 한다(문서에 적음). - 이 노트북에서는 실행하지 못했다. 검증: desktop batch에서 확인. node scripts/run-vitest.ts run tests/unit/check-bundle-output.test.ts tests/unit/run-isolation.test.ts 리뷰 12-R2 명령(stale-bundle-rc=1, stderr에 RUN_OUTPUT_ROOT), check:types, lint, verify:documentation, ci:gate FE-GATE-012 Refs: 1106/12-02
188 lines
7.5 KiB
TypeScript
188 lines
7.5 KiB
TypeScript
import { spawnSync } from "node:child_process";
|
|
import { mkdir, mkdtemp, rm, writeFile } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
|
|
/**
|
|
* 1103/15-03. An over-budget build printed only
|
|
* "Bundle budget or manifest integrity failed: " with nothing after the
|
|
* colon, so the first budget failure a project meets named neither the limit
|
|
* nor the excess. check-bundle runs here on a hand-made build output.
|
|
*/
|
|
const roots: string[] = [];
|
|
|
|
afterEach(async () => {
|
|
await Promise.all(roots.splice(0).map((root) => rm(root, { recursive: true, force: true })));
|
|
});
|
|
|
|
type Output = Readonly<{ path: string; gzipBytes: number }>;
|
|
|
|
async function checkBundle(
|
|
options: Readonly<{
|
|
outputs: readonly Output[];
|
|
manifest: Record<string, unknown>;
|
|
budgets: Record<string, number>;
|
|
/** RUN_OUTPUT_ROOT for the run, and the build written under it. */
|
|
runOutput?: Readonly<{ root: string; outputs: readonly Output[] }>;
|
|
}>,
|
|
) {
|
|
const root = await mkdtemp(path.join(tmpdir(), "check-bundle-output-"));
|
|
roots.push(root);
|
|
const write = async (file: string, value: unknown) => {
|
|
await mkdir(path.dirname(path.join(root, file)), { recursive: true });
|
|
await writeFile(path.join(root, file), `${JSON.stringify(value, null, 2)}\n`);
|
|
};
|
|
const writeBuild = async (buildRoot: string, outputs: readonly Output[]) => {
|
|
await write(path.posix.join(buildRoot, "dist/.vite/manifest.json"), options.manifest);
|
|
await write(path.posix.join(buildRoot, "artifacts/performance/bundle.json"), {
|
|
schemaVersion: 1,
|
|
generatedAt: "2026-11-04T00:00:00.000Z",
|
|
context: { nodeVersion: "v24.14.0", packageManager: "pnpm@11.17.0", runnerImage: "fixture" },
|
|
outputs: outputs.map((output) => ({
|
|
path: `dist/${output.path}`,
|
|
bytes: output.gzipBytes * 3,
|
|
gzipBytes: output.gzipBytes,
|
|
sha256: "a".repeat(64),
|
|
})),
|
|
});
|
|
};
|
|
await write("config/performance/budgets.json", { schemaVersion: 1, bundle: options.budgets });
|
|
await writeBuild(".", options.outputs);
|
|
if (options.runOutput) await writeBuild(options.runOutput.root, options.runOutput.outputs);
|
|
const result = spawnSync(process.execPath, [path.resolve("scripts/check-bundle.ts")], {
|
|
cwd: root,
|
|
encoding: "utf8",
|
|
// Empty is unset (scripts/lib/run-isolation.ts), whatever the runner has.
|
|
env: { ...process.env, RUN_OUTPUT_ROOT: options.runOutput?.root ?? "" },
|
|
});
|
|
return { status: result.status, stdout: result.stdout, stderr: result.stderr };
|
|
}
|
|
|
|
const MANIFEST = {
|
|
"index.html": {
|
|
file: "assets/index-A.js",
|
|
isEntry: true,
|
|
imports: ["_boot"],
|
|
},
|
|
// The entry's own dynamic imports are initial (09-03); a route's are lazy.
|
|
_boot: { file: "assets/boot-B.js", dynamicImports: ["src/lazy.tsx"] },
|
|
"src/lazy.tsx": { file: "assets/lazy-C.js" },
|
|
};
|
|
const OUTPUTS = [
|
|
{ path: "assets/index-A.js", gzipBytes: 400 },
|
|
{ path: "assets/boot-B.js", gzipBytes: 500 },
|
|
{ path: "assets/lazy-C.js", gzipBytes: 300 },
|
|
];
|
|
const BUDGETS = { initialJsGzipBytes: 1_000, initialJsFiles: 2, lazyChunkGzipBytes: 400 };
|
|
|
|
describe("check:bundle failure output (1103/15-03)", () => {
|
|
it("passes and prints the total within budget", async () => {
|
|
const result = await checkBundle({ outputs: OUTPUTS, manifest: MANIFEST, budgets: BUDGETS });
|
|
expect(result.stderr).toBe("");
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toContain("initial JS 900 / 1000 gzip bytes");
|
|
});
|
|
|
|
it("names the measured initial total, the budget and the excess", async () => {
|
|
const result = await checkBundle({
|
|
outputs: OUTPUTS,
|
|
manifest: MANIFEST,
|
|
budgets: { ...BUDGETS, initialJsGzipBytes: 899 },
|
|
});
|
|
expect(result.status).toBe(1);
|
|
expect(result.stderr).toContain("Bundle budget failed (config/performance/budgets.json):");
|
|
expect(result.stderr).toContain("initial JavaScript 900 gzip bytes > budget 899 (over by 1)");
|
|
expect(result.stderr).not.toContain("manifest integrity");
|
|
});
|
|
|
|
it("names each lazy chunk over its budget", async () => {
|
|
const result = await checkBundle({
|
|
outputs: OUTPUTS,
|
|
manifest: MANIFEST,
|
|
budgets: { ...BUDGETS, lazyChunkGzipBytes: 250 },
|
|
});
|
|
expect(result.status).toBe(1);
|
|
expect(result.stderr).toContain(
|
|
"lazy chunk assets/lazy-C.js 300 gzip bytes > budget 250 (over by 50)",
|
|
);
|
|
});
|
|
|
|
// 1103/15-05. The entry preloads every initial file at once; over HTTP/1.1
|
|
// they queue for six connections. A change that adds an initial file is a
|
|
// decision recorded in the budget, not a side effect.
|
|
it("fails when the initial JavaScript has more files than the budget", async () => {
|
|
const result = await checkBundle({
|
|
outputs: OUTPUTS,
|
|
manifest: MANIFEST,
|
|
budgets: { ...BUDGETS, initialJsFiles: 1 },
|
|
});
|
|
expect(result.status).toBe(1);
|
|
expect(result.stderr).toContain("initial JavaScript files 2 > budget 1 (over by 1)");
|
|
});
|
|
|
|
it("reports a manifest integrity failure apart from the budget", async () => {
|
|
const result = await checkBundle({
|
|
outputs: OUTPUTS.filter(({ path: file }) => file !== "assets/boot-B.js"),
|
|
manifest: MANIFEST,
|
|
budgets: BUDGETS,
|
|
});
|
|
expect(result.status).toBe(1);
|
|
expect(result.stderr).toContain("Bundle manifest integrity failed:");
|
|
expect(result.stderr).toContain("output missing from the inventory: assets/boot-B.js");
|
|
expect(result.stderr).not.toContain("Bundle budget failed");
|
|
});
|
|
});
|
|
|
|
/**
|
|
* 1106/12-02. Under RUN_OUTPUT_ROOT scripts/build-frontend.ts writes the build
|
|
* below that folder, and check:bundle (scripts/generate-supply-chain.ts, then
|
|
* scripts/check-bundle.ts) read the checkout's dist/ and artifacts/ anyway: a
|
|
* build over budget under .tmp/ passed on the checkout's earlier build
|
|
* (review run 12-R2). Both stop and name the variable instead.
|
|
*/
|
|
describe("check:bundle with RUN_OUTPUT_ROOT (1106/12-02)", () => {
|
|
it("does not pass the checkout's earlier build while the build writes elsewhere", async () => {
|
|
const result = await checkBundle({
|
|
outputs: OUTPUTS,
|
|
manifest: MANIFEST,
|
|
budgets: BUDGETS,
|
|
runOutput: {
|
|
root: ".tmp/runs/other",
|
|
outputs: OUTPUTS.map((output) => ({ ...output, gzipBytes: output.gzipBytes * 4 })),
|
|
},
|
|
});
|
|
expect(result.stdout).not.toContain("Bundle budget: PASS");
|
|
expect(result.status).toBe(1);
|
|
expect(result.stderr).toContain("RUN_OUTPUT_ROOT=.tmp/runs/other");
|
|
});
|
|
|
|
it("measures the checkout's build when the output root is the checkout", async () => {
|
|
const result = await checkBundle({
|
|
outputs: OUTPUTS,
|
|
manifest: MANIFEST,
|
|
budgets: BUDGETS,
|
|
runOutput: { root: ".", outputs: OUTPUTS },
|
|
});
|
|
expect(result.stderr).toBe("");
|
|
expect(result.status).toBe(0);
|
|
expect(result.stdout).toContain("initial JS 900 / 1000 gzip bytes");
|
|
});
|
|
|
|
it("stops scripts/generate-supply-chain.ts before it reads the checkout's build", async () => {
|
|
const root = await mkdtemp(path.join(tmpdir(), "generate-supply-chain-output-root-"));
|
|
roots.push(root);
|
|
const result = spawnSync(process.execPath, [path.resolve("scripts/generate-supply-chain.ts")], {
|
|
cwd: root,
|
|
encoding: "utf8",
|
|
env: { ...process.env, RUN_OUTPUT_ROOT: ".tmp/runs/other" },
|
|
});
|
|
expect(result.status).toBe(1);
|
|
expect(result.stderr).toContain(
|
|
"scripts/generate-supply-chain.ts reads the build at this checkout's paths",
|
|
);
|
|
expect(result.stderr).toContain("RUN_OUTPUT_ROOT=.tmp/runs/other");
|
|
});
|
|
});
|