review-followup Wave 3: 설정 prefix app.* 통일(P20), Wave 3 종료

- 결정 16: `ca-skeleton.*`·`backend.graphql` 등 → `app.*`(APP_* env 키 이름 유지), selector 키 상수 하나(`CapabilitySelectors`),
  바인딩만 되던 `streaming-idle` 삭제
- `StrictSettingsBinder`가 env 오타까지 거부 — 모든 capability(graphql·websocket·mongo는 edge 제약으로 파일만 strict),
  httpclient 리플렉션 `HttpClientEnvironmentKeys` 삭제
- persistence-jpa가 `APP_DATASOURCE_PASSWORD` secret 요구를 기여(bootstrap이 JPA 스위치를 읽지 않음), Redis ACL fixture에서 pub/sub 권한 제거
- 결함 수정: SMTP 설정 env 이름 충돌(P20-new-1), `bindExcept`가 system env까지 filter(P20-new-2), graphql 빈 deployment-mode 메시지(P20-new-6)
- 통합: P30과 충돌 11건(P30의 명시적 bean 구조 유지), P30 코드의 옛 키를 app.*로, persistence-jpa 포맷
- 현황표: 소유자 결정 36(persistence-jpa 설정은 플랫폼 키만 app.persistence-jpa.*로, 공유 기능 트리 예외), 재개 문서에 일시 정지 상태

Wave 3 종료 검증: check · ci verifyDependencyLocks --warning-mode=fail(714 task) · mainCheck · architectureCheck
verifyPublicPathSnapshot :app-bootstrap:verifyEnvKeys configContractCheck · :app-bootstrap:integrationTest
:sample-portfolio:integrationTest :sample-portfolio:systemTest · integrationCheck · -p build-logic test ·
-p optional-platforms ci · :app-bootstrap:qualificationBootJar releaseCheck 통과

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
donghyeon-ka
2026-09-29 17:01:54 +09:00
co-authored by Claude Opus 5.5
parent e08c3ecccc
commit 371ace4a3b
11 changed files with 34 additions and 35 deletions
@@ -4,7 +4,7 @@ Every capability in `:grpc-advanced:*`, its grade, and what it would take to rai
`GrpcAdvancedSupportMatrix` is the machine-readable form; `GrpcAdvancedCapability.defaultGrade`
carries the same values.
All capabilities are off by default. Flags are `ca-skeleton.grpc.advanced.<capability>.enabled`.
All capabilities are off by default. Flags are `app.grpc.advanced.<capability>.enabled`.
## Grades
+1 -1
View File
@@ -3,7 +3,7 @@
Scope: the `:grpc-advanced:*` family. Everything here is off by default and stays off until a
deployment names it. Nothing in this family ships in a runtime composition today.
Flags are `ca-skeleton.grpc.advanced.<capability>.enabled`. `GrpcAdvancedCapability` owns the list of
Flags are `app.grpc.advanced.<capability>.enabled`. `GrpcAdvancedCapability` owns the list of
capability names; `GrpcAdvancedSupportMatrix` owns their current grades.
---
+4 -4
View File
@@ -5,8 +5,8 @@ empty — so nothing here fires in production yet. It is written now because the
the ones an on-call cannot work out from first principles at three in the morning, and shipping the
behaviour before the runbook means the first person to meet one is doing that.
Configuration lives under `ca-skeleton.grpc.platform.*` and is bound by `GrpcPlatformProperties`.
The platform does not start unless `ca-skeleton.grpc.platform.enabled=true`.
Configuration lives under `app.grpc.platform.*` and is bound by `GrpcPlatformProperties`.
The platform does not start unless `app.grpc.platform.enabled=true`.
---
@@ -94,7 +94,7 @@ capacity on nothing.
means the bottleneck is admission, not the work.
2. Check which saturation counter is moving — executor, channel or flow control. They look identical
in a latency graph and have different fixes.
3. Raising `ca-skeleton.grpc.platform.executor-queue-capacity` defers the problem; it does not remove
3. Raising `app.grpc.platform.executor-queue-capacity` defers the problem; it does not remove
it. `GrpcExecutorProfile` refuses a queue above ten thousand for that reason.
---
@@ -138,5 +138,5 @@ construction rather than redacted.
- **Reflection in production.** `GrpcReflectionMode.defaultFor` returns `DISABLED` for `STAGE` and
`PROD`. Reflection publishes the whole schema to anyone who can open a connection.
- **Every advanced capability.** See `docs/runbooks/grpc-advanced-capabilities.md`.
- **The platform itself.** `ca-skeleton.grpc.platform.enabled` defaults to false, and every `:grpc:*`
- **The platform itself.** `app.grpc.platform.enabled` defaults to false, and every `:grpc:*`
leaf is build-only in the registry.
+1 -1
View File
@@ -31,7 +31,7 @@ capability마다 별도 flag를 갖는다. 하나의 "advanced" 스위치로 묶
| `WATCH` | X (추적만) | — |
| `DISABLED` | X | — |
property key는 `ca-skeleton.grpc.advanced.<capability>.enabled`이고 전부 기본 off다.
property key는 `app.grpc.advanced.<capability>.enabled`이고 전부 기본 off다.
`GrpcAdvancedModuleGuard`가 세 조건(flag 미설정 / grade가 시작 불가 / production 승인 없음)을
구분해서 거부하며, 세 경우의 조치가 다르므로 메시지도 다르다.
+1 -1
View File
@@ -6,7 +6,7 @@ plugins {
// The capabilities the Stable platform deliberately excludes, each behind its own capability flag:
//
// bootstrap capability grades, the `ca-skeleton.grpc.advanced.*` feature-flag contract, the
// bootstrap capability grades, the `app.grpc.advanced.*` feature-flag contract, the
// module guard that refuses an unflagged capability, the per-capability promotion
// gate
// edition Protobuf Edition 2024 opt-in lane and Edition 2026 watch lane
@@ -48,14 +48,14 @@ public enum GrpcAdvancedCapability {
this.defaultGrade = defaultGrade;
}
/** The property suffix under {@code ca-skeleton.grpc.advanced}. */
/** The property suffix under {@code app.grpc.advanced}. */
public String flagName() {
return flagName;
}
/** The full property key that enables this capability. */
public String propertyKey() {
return "ca-skeleton.grpc.advanced." + flagName + ".enabled";
return "app.grpc.advanced." + flagName + ".enabled";
}
/** How ready this capability is today. */
@@ -23,8 +23,7 @@ class GrpcAdvancedModuleGuardTest {
@Test
@DisplayName("each capability has its own flag, not a shared one")
void eachCapabilityHasItsOwnFlag() {
assertThat(GrpcAdvancedCapability.XDS.propertyKey())
.isEqualTo("ca-skeleton.grpc.advanced.xds.enabled");
assertThat(GrpcAdvancedCapability.XDS.propertyKey()).isEqualTo("app.grpc.advanced.xds.enabled");
assertThat(GrpcAdvancedCapability.GRPC_WEB.propertyKey())
.isNotEqualTo(GrpcAdvancedCapability.XDS.propertyKey());
@@ -43,7 +42,7 @@ class GrpcAdvancedModuleGuardTest {
GrpcAdvancedModuleGuard.require(
GrpcAdvancedFeatureFlags.forDevelopment(), GrpcAdvancedCapability.REACTOR))
.isInstanceOf(GrpcAdvancedCapabilityDisabledException.class)
.hasMessageContaining("ca-skeleton.grpc.advanced.reactor.enabled=true");
.hasMessageContaining("app.grpc.advanced.reactor.enabled=true");
}
@Test
@@ -33,7 +33,7 @@ import org.springframework.context.annotation.Bean;
*/
@AutoConfiguration
@ConditionalOnProperty(
prefix = "ca-skeleton.grpc.platform",
prefix = "app.grpc.platform",
name = "enabled",
havingValue = "true",
matchIfMissing = false)
@@ -6,7 +6,7 @@ import dev.caskeleton.grpc.server.GrpcServerTransport;
import org.springframework.boot.context.properties.ConfigurationProperties;
/**
* The gRPC platform's typed configuration, bound from {@code ca-skeleton.grpc.platform.*}.
* The gRPC platform's typed configuration, bound from {@code app.grpc.platform.*}.
*
* <p>Off by default, like every other optional capability in this repository. A platform that
* starts because its jar is on the classpath is a platform that opens a port on a deployment nobody
@@ -16,7 +16,7 @@ import org.springframework.boot.context.properties.ConfigurationProperties;
* leaving a setting at its default — which is how a deployment ends up with production reflection
* enabled because somebody wrote {@code reflection-mode} under the wrong prefix.
*/
@ConfigurationProperties(prefix = "ca-skeleton.grpc.platform", ignoreUnknownFields = false)
@ConfigurationProperties(prefix = "app.grpc.platform", ignoreUnknownFields = false)
public class GrpcPlatformProperties {
/** Whether the platform is assembled at all. */
@@ -82,7 +82,7 @@ public final class GrpcPlatformStartupValidator {
}
if (properties.getEnvironment() == null) {
violations.add(
"ca-skeleton.grpc.platform.environment is not set; the TLS and reflection floors depend on"
"app.grpc.platform.environment is not set; the TLS and reflection floors depend on"
+ " it, so it is refused rather than assumed LOCAL");
return;
}
@@ -17,11 +17,11 @@ class GrpcPlatformAutoConfigurationContextTest {
() ->
start(
Map.of(
"ca-skeleton.grpc.platform.enabled", "true",
"ca-skeleton.grpc.platform.environment", "PROD",
"ca-skeleton.grpc.platform.transport", "NETTY_SHADED",
"ca-skeleton.grpc.platform.tls-enabled", "true",
"ca-skeleton.grpc.platform.trust-all-certificates", "true")))
"app.grpc.platform.enabled", "true",
"app.grpc.platform.environment", "PROD",
"app.grpc.platform.transport", "NETTY_SHADED",
"app.grpc.platform.tls-enabled", "true",
"app.grpc.platform.trust-all-certificates", "true")))
.isInstanceOf(GrpcPlatformConfigurationException.class)
.hasMessageContaining("trust-all is enabled in PROD")
.hasMessageContaining("providing none");
@@ -35,15 +35,15 @@ class GrpcPlatformAutoConfigurationContextTest {
() ->
start(
Map.of(
"ca-skeleton.grpc.platform.enabled", "true",
"ca-skeleton.grpc.platform.transport", "NETTY_SHADED",
"ca-skeleton.grpc.platform.tls-enabled", "false",
"ca-skeleton.grpc.platform.reflection-mode", "ENABLED")));
"app.grpc.platform.enabled", "true",
"app.grpc.platform.transport", "NETTY_SHADED",
"app.grpc.platform.tls-enabled", "false",
"app.grpc.platform.reflection-mode", "ENABLED")));
// then
assertThat(failure)
.isInstanceOf(GrpcPlatformConfigurationException.class)
.hasMessageContaining("ca-skeleton.grpc.platform.environment is not set");
.hasMessageContaining("app.grpc.platform.environment is not set");
}
@Test
@@ -51,11 +51,11 @@ class GrpcPlatformAutoConfigurationContextTest {
try (AnnotationConfigApplicationContext context =
start(
Map.of(
"ca-skeleton.grpc.platform.enabled", "true",
"ca-skeleton.grpc.platform.environment", "LOCAL",
"ca-skeleton.grpc.platform.transport", "NETTY_SHADED",
"ca-skeleton.grpc.platform.executor-queue-capacity", "32",
"ca-skeleton.grpc.platform.executor-max-pool-size", "4"))) {
"app.grpc.platform.enabled", "true",
"app.grpc.platform.environment", "LOCAL",
"app.grpc.platform.transport", "NETTY_SHADED",
"app.grpc.platform.executor-queue-capacity", "32",
"app.grpc.platform.executor-max-pool-size", "4"))) {
assertThat(context.getBean(GrpcPlatformProperties.class).isEnabled()).isTrue();
assertThat(
context.getBeansOfType(
@@ -69,9 +69,9 @@ class GrpcPlatformAutoConfigurationContextTest {
try (AnnotationConfigApplicationContext context =
start(
Map.of(
"ca-skeleton.grpc.platform.enabled", "true",
"ca-skeleton.grpc.platform.environment", "LOCAL",
"ca-skeleton.grpc.platform.transport", "NETTY"))) {
"app.grpc.platform.enabled", "true",
"app.grpc.platform.environment", "LOCAL",
"app.grpc.platform.transport", "NETTY"))) {
assertThat(context.getBean(dev.caskeleton.grpc.server.GrpcServerProfile.class).transport())
.isEqualTo(dev.caskeleton.grpc.server.GrpcServerTransport.NETTY);
}