Carries 359 template commits, tag v0.2.0 plus one documentation commit: the generator-built feature index with its app, bounded-context and feature declarations, the src/platform kernel and scale tooling, the 2026-09-24 src review fixes, and the 2026-09-25 maturity review round with its CHANGELOG [보안]/[계약] rows. 691 of the 824 template paths are applied, 85 of them merged with product changes; 127 are not carried. Product identity is unchanged: name, version 0.1.0, routes, design and the TechLog domain. Three decisions worth naming. TechLog stays composed directly, as the last two syncs recorded; its directory carries a NOT_INSTALLED marker that says so, and every installed-* composer takes the template's projection with TechLog added on top. The reference sample is no longer installed: the template now installs a feature only through feature-module.ts and context-routes.ts, which load the screens this product deleted, so its three operations, six schemas and one topic leave the registries, recorded as registry change evidence. And AppRouter mounts the platform and TechLog routes only; the template's bounded-context route gateway waits for a generator-installed feature. Required fixes: readSubject on the BFF session owner (without it every HTTP Studio session would close as integration-failed), zod through the facade in nine TechLog files, noUnusedLocals, and public/config.json written out to match the local profile. Derived baselines were recomputed after reproducing both sides' values: CI contract 101 commands / 106 references / 141 artifacts, gate shape c9adcf85; registry approval 2dc6c3a3; the runtime config schema baseline equals the schema at8210d48. Verified here: types, lint, architecture, adapter inventory, CI contract, i18n, design system, diagnostics, browser security, dev release manifest, TechLog contract and build pass; 220 component, 155 integration, 15 contract, 418 TechLog, 43 reference-feature, 18 recipe and 46 release-coherence tests pass, and 2381 of 2383 unit tests. Reproduced at8210d48first and unchanged: check:registries (byte-identical), test:runtime-schema, verify:documentation. Brought by the template and escalated rather than suppressed: check:request-fanout on TechLog's cursor pagination, check:remediation-ledger (fails upstream too), the shared-chunk hash test, and the registry-dependent sample removal and second-feature tests. Playwright suites were not run. Full record, the five open questions and the follow-ups in docs/operations/template-sync-2026-09-29.md. (cherry picked from commit b2170cf265dea45dc9cc05d3c61e627e97f31cdb)
637 lines
18 KiB
TypeScript
637 lines
18 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { describe, expect, it, vi } from "vitest";
|
|
|
|
import {
|
|
DEFAULT_NATIVE_PICKER_FOCUS_GRACE_MS,
|
|
EnhancedFilePicker,
|
|
NativeInputFilePicker,
|
|
} from "../../src/adapters/browser-files/browser-file-picker.ts";
|
|
import { BrowserFileVault } from "../../src/adapters/browser-files/browser-file-vault.ts";
|
|
import {
|
|
BrowserFilePolicyRegistry,
|
|
browserFilePolicyReference,
|
|
} from "../../src/adapters/browser-files/browser-file-policy-registry.ts";
|
|
import type { RegisteredFileSelectionPolicy } from "../../src/adapters/browser-files/file-policy.ts";
|
|
|
|
const policyDefinition: RegisteredFileSelectionPolicy = Object.freeze({
|
|
policyId: "attachment-v1",
|
|
purpose: "attachment",
|
|
classification: "PERSONAL",
|
|
multiple: false,
|
|
maxCount: 1,
|
|
maxFileBytes: 100,
|
|
maxTotalBytes: 100,
|
|
allowEmpty: false,
|
|
accept: Object.freeze([
|
|
Object.freeze({
|
|
mediaType: "text/plain",
|
|
extensions: Object.freeze([".txt"]),
|
|
}),
|
|
]),
|
|
});
|
|
const policy = browserFilePolicyReference(
|
|
"attachments",
|
|
"select-text-attachment",
|
|
);
|
|
|
|
function createHarness(
|
|
selection: RegisteredFileSelectionPolicy = policyDefinition,
|
|
vaultOptions: Readonly<{
|
|
createReference?: () => string;
|
|
}> = {},
|
|
): Readonly<{
|
|
policies: BrowserFilePolicyRegistry;
|
|
vault: BrowserFileVault;
|
|
}> {
|
|
const policies = new BrowserFilePolicyRegistry({
|
|
profiles: [{ reference: policy, selection }],
|
|
hardLimits: {
|
|
maxInspectionBytes: 64 * 1024,
|
|
maxRetainedFileBytes: 1_024,
|
|
maxPreviewBytes: 1_024,
|
|
maxObjectUrlBytes: 1_024,
|
|
maxTransferBytes: 1_024,
|
|
},
|
|
});
|
|
return {
|
|
policies,
|
|
vault: new BrowserFileVault({ policies, ...vaultOptions }),
|
|
};
|
|
}
|
|
|
|
function labelledFileInput(): HTMLInputElement {
|
|
const label = document.createElement("label");
|
|
label.textContent = "Choose attachment";
|
|
const input = document.createElement("input");
|
|
input.type = "file";
|
|
label.append(input);
|
|
document.body.append(label);
|
|
return input;
|
|
}
|
|
|
|
describe("browser file pickers", () => {
|
|
it("treats native input cancellation as a normal dismissed outcome", async () => {
|
|
const input = labelledFileInput();
|
|
Object.defineProperty(input, "click", {
|
|
configurable: true,
|
|
value: vi.fn(() => {
|
|
queueMicrotask(() => input.dispatchEvent(new Event("cancel")));
|
|
}),
|
|
});
|
|
const baselineShowPicker = vi.fn();
|
|
Object.defineProperty(input, "showPicker", {
|
|
configurable: true,
|
|
value: baselineShowPicker,
|
|
});
|
|
const harness = createHarness();
|
|
const picker = new NativeInputFilePicker({
|
|
input,
|
|
...harness,
|
|
userActivation: { isActive: true },
|
|
});
|
|
|
|
expect(await picker.select({ policy })).toEqual({
|
|
ok: true,
|
|
value: { kind: "DISMISSED" },
|
|
});
|
|
expect(baselineShowPicker).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("refuses to open the native input without user activation (02-08)", async () => {
|
|
const input = labelledFileInput();
|
|
const click = vi.fn(() => {
|
|
queueMicrotask(() => input.dispatchEvent(new Event("cancel")));
|
|
});
|
|
Object.defineProperty(input, "click", {
|
|
configurable: true,
|
|
value: click,
|
|
});
|
|
const picker = new NativeInputFilePicker({
|
|
input,
|
|
...createHarness(),
|
|
userActivation: { isActive: false },
|
|
});
|
|
|
|
expect(await picker.select({ policy })).toMatchObject({
|
|
ok: false,
|
|
error: { code: "PERMISSION_DENIED", operation: "FILE_SELECT" },
|
|
});
|
|
expect(click).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("resets the native input and supports same-file reselection", async () => {
|
|
const input = labelledFileInput();
|
|
const selected = new File(["hello"], "notes.txt", {
|
|
type: "text/plain",
|
|
lastModified: 1,
|
|
});
|
|
Object.defineProperty(input, "files", {
|
|
configurable: true,
|
|
value: [selected],
|
|
});
|
|
const click = vi.fn(() => {
|
|
queueMicrotask(() => input.dispatchEvent(new Event("change")));
|
|
});
|
|
Object.defineProperty(input, "click", {
|
|
configurable: true,
|
|
value: click,
|
|
});
|
|
let sequence = 0;
|
|
const { policies, vault } = createHarness(policyDefinition, {
|
|
createReference: () => `file:${sequence++}`,
|
|
});
|
|
const picker = new NativeInputFilePicker({
|
|
input,
|
|
vault,
|
|
policies,
|
|
userActivation: { isActive: true },
|
|
});
|
|
|
|
const first = await picker.select({ policy });
|
|
const second = await picker.select({ policy });
|
|
expect(first).toMatchObject({
|
|
ok: true,
|
|
value: { kind: "SELECTED" },
|
|
});
|
|
expect(second).toMatchObject({
|
|
ok: true,
|
|
value: { kind: "SELECTED" },
|
|
});
|
|
expect(click).toHaveBeenCalledTimes(2);
|
|
expect(input.value).toBe("");
|
|
expect(vault.activeReferenceCount).toBe(2);
|
|
});
|
|
|
|
it("snapshots selection policy before awaiting picker events", async () => {
|
|
const input = labelledFileInput();
|
|
Object.defineProperty(input, "click", {
|
|
configurable: true,
|
|
value: vi.fn(),
|
|
});
|
|
const mutablePolicy = {
|
|
policyId: "mutable-v1",
|
|
purpose: "attachment",
|
|
classification: "PERSONAL" as const,
|
|
multiple: false,
|
|
maxCount: 1,
|
|
maxFileBytes: 100,
|
|
maxTotalBytes: 100,
|
|
allowEmpty: false,
|
|
accept: [
|
|
{ mediaType: "text/plain", extensions: [".txt"] },
|
|
],
|
|
};
|
|
const harness = createHarness(mutablePolicy, {
|
|
createReference: () => "file:snapshot",
|
|
});
|
|
const picker = new NativeInputFilePicker({
|
|
input,
|
|
...harness,
|
|
userActivation: { isActive: true },
|
|
});
|
|
const pending = picker.select({ policy });
|
|
|
|
mutablePolicy.maxFileBytes = 1;
|
|
mutablePolicy.maxTotalBytes = 1;
|
|
mutablePolicy.accept[0]!.extensions[0] = ".png";
|
|
Object.defineProperty(input, "files", {
|
|
configurable: true,
|
|
value: [
|
|
new File(["hello"], "notes.txt", {
|
|
type: "text/plain",
|
|
lastModified: 1,
|
|
}),
|
|
],
|
|
});
|
|
input.dispatchEvent(new Event("change"));
|
|
|
|
expect(await pending).toMatchObject({
|
|
ok: true,
|
|
value: { kind: "SELECTED" },
|
|
});
|
|
});
|
|
|
|
it("honors AbortSignal while a native dialog is pending", async () => {
|
|
const input = labelledFileInput();
|
|
Object.defineProperty(input, "click", {
|
|
configurable: true,
|
|
value: vi.fn(),
|
|
});
|
|
const harness = createHarness();
|
|
const picker = new NativeInputFilePicker({
|
|
input,
|
|
...harness,
|
|
userActivation: { isActive: true },
|
|
});
|
|
const controller = new AbortController();
|
|
const pending = picker.select({ policy, signal: controller.signal });
|
|
controller.abort();
|
|
|
|
expect(await pending).toMatchObject({
|
|
ok: false,
|
|
error: { code: "ABORTED" },
|
|
});
|
|
});
|
|
|
|
it("gives a late selected FileList a grace window after focus returns", async () => {
|
|
const input = labelledFileInput();
|
|
const selected = new File(["late"], "late.txt", {
|
|
type: "text/plain",
|
|
lastModified: 1,
|
|
});
|
|
let fallback: (() => void) | undefined;
|
|
let delay: number | undefined;
|
|
const clearTimeout = vi.fn();
|
|
Object.defineProperty(input, "click", {
|
|
configurable: true,
|
|
value: vi.fn(() => {
|
|
window.dispatchEvent(new Event("focus"));
|
|
}),
|
|
});
|
|
const { policies, vault } = createHarness(policyDefinition, {
|
|
createReference: () => "file:late",
|
|
});
|
|
const picker = new NativeInputFilePicker({
|
|
input,
|
|
vault,
|
|
policies,
|
|
userActivation: { isActive: true },
|
|
scheduler: {
|
|
setTimeout(callback, delayMs) {
|
|
fallback = callback;
|
|
delay = delayMs;
|
|
return 1;
|
|
},
|
|
clearTimeout,
|
|
},
|
|
});
|
|
const pending = picker.select({ policy });
|
|
expect(delay).toBe(DEFAULT_NATIVE_PICKER_FOCUS_GRACE_MS);
|
|
|
|
Object.defineProperty(input, "files", {
|
|
configurable: true,
|
|
value: [selected],
|
|
});
|
|
fallback?.();
|
|
|
|
expect(await pending).toMatchObject({
|
|
ok: true,
|
|
value: {
|
|
kind: "SELECTED",
|
|
files: [{ displayName: "late.txt" }],
|
|
},
|
|
});
|
|
expect(vault.activeReferenceCount).toBe(1);
|
|
});
|
|
|
|
it("stops the focus fallback once a native cancel event was observed (Q-6.2-8)", async () => {
|
|
const input = labelledFileInput();
|
|
const selected = new File(["slow"], "slow.txt", {
|
|
type: "text/plain",
|
|
lastModified: 1,
|
|
});
|
|
let onClick = (): void => {
|
|
queueMicrotask(() => input.dispatchEvent(new Event("cancel")));
|
|
};
|
|
Object.defineProperty(input, "click", {
|
|
configurable: true,
|
|
value: vi.fn(() => onClick()),
|
|
});
|
|
const scheduled: Array<() => void> = [];
|
|
const { policies, vault } = createHarness(policyDefinition, {
|
|
createReference: () => "file:slow",
|
|
});
|
|
const picker = new NativeInputFilePicker({
|
|
input,
|
|
vault,
|
|
policies,
|
|
userActivation: { isActive: true },
|
|
scheduler: {
|
|
setTimeout(callback) {
|
|
scheduled.push(callback);
|
|
return scheduled.length;
|
|
},
|
|
clearTimeout() {},
|
|
},
|
|
});
|
|
|
|
// This engine supports the native cancel event.
|
|
expect(await picker.select({ policy })).toEqual({
|
|
ok: true,
|
|
value: { kind: "DISMISSED" },
|
|
});
|
|
|
|
// A cloud provider returns focus first and dispatches change only after
|
|
// the file has been fetched, well past the focus grace.
|
|
onClick = () => window.dispatchEvent(new Event("focus"));
|
|
const pending = picker.select({ policy });
|
|
for (const callback of scheduled.splice(0)) callback();
|
|
Object.defineProperty(input, "files", {
|
|
configurable: true,
|
|
value: [selected],
|
|
});
|
|
input.dispatchEvent(new Event("change"));
|
|
|
|
expect(await pending).toMatchObject({
|
|
ok: true,
|
|
value: { kind: "SELECTED", files: [{ displayName: "slow.txt" }] },
|
|
});
|
|
});
|
|
|
|
it("lets the native cancel event settle before the focus fallback", async () => {
|
|
const input = labelledFileInput();
|
|
let fallback: (() => void) | undefined;
|
|
const clearTimeout = vi.fn();
|
|
Object.defineProperty(input, "click", {
|
|
configurable: true,
|
|
value: vi.fn(() => {
|
|
window.dispatchEvent(new Event("focus"));
|
|
input.dispatchEvent(new Event("cancel"));
|
|
}),
|
|
});
|
|
const { policies, vault } = createHarness();
|
|
const picker = new NativeInputFilePicker({
|
|
input,
|
|
vault,
|
|
policies,
|
|
userActivation: { isActive: true },
|
|
scheduler: {
|
|
setTimeout(callback) {
|
|
fallback = callback;
|
|
return 1;
|
|
},
|
|
clearTimeout,
|
|
},
|
|
});
|
|
|
|
expect(await picker.select({ policy })).toEqual({
|
|
ok: true,
|
|
value: { kind: "DISMISSED" },
|
|
});
|
|
expect(clearTimeout).toHaveBeenCalledWith(1);
|
|
fallback?.();
|
|
expect(vault.activeReferenceCount).toBe(0);
|
|
});
|
|
|
|
it("captures native input, window, and scheduler methods at construction", async () => {
|
|
const input = labelledFileInput();
|
|
let focus: EventListener | undefined;
|
|
const originalWindowAdd = vi.fn(
|
|
(_type: string, listener: EventListener) => {
|
|
focus = listener;
|
|
},
|
|
);
|
|
const originalWindowRemove = vi.fn();
|
|
const windowHost = {
|
|
addEventListener: originalWindowAdd,
|
|
removeEventListener: originalWindowRemove,
|
|
};
|
|
const originalSetTimeout = vi.fn(
|
|
(callback: () => void) => {
|
|
queueMicrotask(callback);
|
|
return 1;
|
|
},
|
|
);
|
|
const originalClearTimeout = vi.fn();
|
|
const scheduler = {
|
|
setTimeout: originalSetTimeout,
|
|
clearTimeout: originalClearTimeout,
|
|
};
|
|
const originalClick = vi.fn(() => {
|
|
focus?.(new Event("focus"));
|
|
});
|
|
const replacedClick = vi.fn();
|
|
Object.defineProperty(input, "click", {
|
|
configurable: true,
|
|
writable: true,
|
|
value: originalClick,
|
|
});
|
|
const harness = createHarness();
|
|
const picker = new NativeInputFilePicker({
|
|
input,
|
|
...harness,
|
|
window: windowHost as Pick<
|
|
Window,
|
|
"addEventListener" | "removeEventListener"
|
|
>,
|
|
scheduler,
|
|
userActivation: { isActive: true },
|
|
focusFallbackGraceMs: 0,
|
|
});
|
|
|
|
input.click = replacedClick;
|
|
windowHost.addEventListener = vi.fn();
|
|
windowHost.removeEventListener = vi.fn();
|
|
scheduler.setTimeout = vi.fn();
|
|
scheduler.clearTimeout = vi.fn();
|
|
|
|
expect(await picker.select({ policy })).toEqual({
|
|
ok: true,
|
|
value: { kind: "DISMISSED" },
|
|
});
|
|
expect(originalClick).toHaveBeenCalledOnce();
|
|
expect(replacedClick).not.toHaveBeenCalled();
|
|
expect(originalWindowAdd).toHaveBeenCalledOnce();
|
|
expect(originalWindowRemove).toHaveBeenCalledOnce();
|
|
expect(originalSetTimeout).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it("requires a connected and labelled file input", async () => {
|
|
const input = document.createElement("input");
|
|
input.type = "file";
|
|
const harness = createHarness();
|
|
const picker = new NativeInputFilePicker({
|
|
input,
|
|
...harness,
|
|
userActivation: { isActive: true },
|
|
});
|
|
|
|
expect(await picker.select({ policy })).toMatchObject({
|
|
ok: false,
|
|
error: { code: "INVALID_INPUT" },
|
|
});
|
|
});
|
|
|
|
it("keeps enhanced dismissal distinct from an active abort", async () => {
|
|
const dismissedHarness = createHarness();
|
|
const dismissed = new EnhancedFilePicker({
|
|
showOpenFilePicker: async () => {
|
|
throw new DOMException("closed", "AbortError");
|
|
},
|
|
...dismissedHarness,
|
|
userActivation: { isActive: true },
|
|
});
|
|
expect(await dismissed.select({ policy })).toEqual({
|
|
ok: true,
|
|
value: { kind: "DISMISSED" },
|
|
});
|
|
|
|
let rejectPicker:
|
|
| ((reason: DOMException) => void)
|
|
| undefined;
|
|
const controller = new AbortController();
|
|
const abortedHarness = createHarness();
|
|
const aborted = new EnhancedFilePicker({
|
|
showOpenFilePicker: () =>
|
|
new Promise((_, reject: (reason: DOMException) => void) => {
|
|
rejectPicker = reject;
|
|
}),
|
|
...abortedHarness,
|
|
userActivation: { isActive: true },
|
|
});
|
|
const pending = aborted.select({
|
|
policy,
|
|
signal: controller.signal,
|
|
});
|
|
controller.abort();
|
|
rejectPicker?.(new DOMException("closed", "AbortError"));
|
|
expect(await pending).toMatchObject({
|
|
ok: false,
|
|
error: { code: "ABORTED" },
|
|
});
|
|
});
|
|
|
|
it("settles a pending enhanced picker when the runtime is disposed", async () => {
|
|
// R3-2 characterization: dispose ends the wait even though the native
|
|
// picker never settles, and a late native result changes nothing.
|
|
let resolvePicker: ((handles: never[]) => void) | undefined;
|
|
const harness = createHarness();
|
|
const picker = new EnhancedFilePicker({
|
|
showOpenFilePicker: () =>
|
|
new Promise<never[]>((resolve) => {
|
|
resolvePicker = resolve;
|
|
}),
|
|
...harness,
|
|
userActivation: { isActive: true },
|
|
});
|
|
const pending = picker.select({
|
|
policy,
|
|
signal: new AbortController().signal,
|
|
});
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
picker.dispose();
|
|
resolvePicker?.([]);
|
|
expect(await pending).toMatchObject({
|
|
ok: false,
|
|
error: { code: "ABORTED" },
|
|
});
|
|
});
|
|
|
|
it("calls an injected window picker without rebinding its receiver", async () => {
|
|
const harness = createHarness();
|
|
const picker = new EnhancedFilePicker({
|
|
// A Window operation throws "Illegal invocation" unless `this` is the
|
|
// Window. Web IDL maps an undefined `this` to the global object.
|
|
showOpenFilePicker: function (this: unknown) {
|
|
if (this !== undefined && this !== globalThis) {
|
|
throw new TypeError("Illegal invocation");
|
|
}
|
|
return Promise.resolve([
|
|
{
|
|
kind: "file" as const,
|
|
name: "safe.txt",
|
|
async getFile() {
|
|
return new File(["safe"], "safe.txt", {
|
|
type: "text/plain",
|
|
lastModified: 1,
|
|
});
|
|
},
|
|
},
|
|
]);
|
|
},
|
|
...harness,
|
|
userActivation: { isActive: true },
|
|
});
|
|
|
|
expect(await picker.select({ policy })).toMatchObject({
|
|
ok: true,
|
|
value: { kind: "SELECTED" },
|
|
});
|
|
});
|
|
|
|
it("rejects excessive enhanced selections before reading handles", async () => {
|
|
const getFile = vi.fn(async () => new File(["a"], "a.txt"));
|
|
const multiplePolicy = {
|
|
...policyDefinition,
|
|
multiple: true,
|
|
maxCount: 1,
|
|
};
|
|
const harness = createHarness(multiplePolicy);
|
|
const picker = new EnhancedFilePicker({
|
|
showOpenFilePicker: async () => [
|
|
{ kind: "file", name: "a.txt", getFile },
|
|
{ kind: "file", name: "b.txt", getFile },
|
|
],
|
|
...harness,
|
|
userActivation: { isActive: true },
|
|
});
|
|
|
|
expect(await picker.select({ policy })).toMatchObject({
|
|
ok: false,
|
|
error: { code: "LIMIT_EXCEEDED" },
|
|
});
|
|
expect(getFile).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("snapshots an enhanced picker request before awaiting the host", async () => {
|
|
let resolvePicker:
|
|
| ((handles: readonly {
|
|
kind: "file";
|
|
name: string;
|
|
getFile(): Promise<File>;
|
|
}[]) => void)
|
|
| undefined;
|
|
const harness = createHarness();
|
|
const picker = new EnhancedFilePicker({
|
|
showOpenFilePicker: () =>
|
|
new Promise((resolve) => {
|
|
resolvePicker = resolve;
|
|
}),
|
|
...harness,
|
|
userActivation: { isActive: true },
|
|
});
|
|
const originalController = new AbortController();
|
|
const replacementController = new AbortController();
|
|
const request = {
|
|
policy,
|
|
signal: originalController.signal,
|
|
};
|
|
const pending = picker.select(request);
|
|
|
|
(
|
|
request as {
|
|
policy: typeof policy;
|
|
signal: AbortSignal;
|
|
}
|
|
).policy = browserFilePolicyReference(
|
|
"forged",
|
|
"forged",
|
|
);
|
|
(
|
|
request as { signal: AbortSignal }
|
|
).signal = replacementController.signal;
|
|
replacementController.abort();
|
|
resolvePicker?.([
|
|
{
|
|
kind: "file",
|
|
name: "safe.txt",
|
|
async getFile() {
|
|
return new File(["safe"], "safe.txt", {
|
|
type: "text/plain",
|
|
lastModified: 1,
|
|
});
|
|
},
|
|
},
|
|
]);
|
|
|
|
expect(await pending).toMatchObject({
|
|
ok: true,
|
|
value: {
|
|
kind: "SELECTED",
|
|
files: [{ displayName: "safe.txt" }],
|
|
},
|
|
});
|
|
});
|
|
});
|