DongHyeonkaandClaude Opus 5
cf45bcc7dc
`/studio/assets` was the one route in the TechLog route contract missing
from `TECH_LOG_CANONICAL_ROUTES` and `TECH_LOG_STUDIO_STATE_PATHS`, so it
had no golden, no responsive-overflow check, and no Axe scan. That gap was
not hypothetical: the responsive overflow just fixed in the Asset search row
shipped in two places and was only caught in the Picker, which has a golden;
the Library's identical copy would have gone unseen.
Verifying the render before capturing anything turned up a second defect.
`studioSpaPathPatterns` in the production serving contract never listed
`/studio/assets`, so a hard navigation or reload of that URL was answered
with the in-shell Studio 404 -- the screen was reachable only by client-side
navigation from another Studio page. A golden taken then would have frozen a
404. With the pattern added, the route serves 200 text/html like its
siblings, and the page renders correctly at both breakpoints:
scrollWidth == clientWidth == viewport at 360 and 1440, `main` and the `h1`
visible, the search label/input/button all inside the 360px viewport, and no
critical or serious Axe violations in chromium.
Three new goldens, no existing golden regenerated:
tech-log-studio-assets-{360,1440} from the canonical route list and
tech-log-studio-asset-library-1440 from the Studio state list, matching how
every other Studio route appears in both. `pnpm test:visual` is 133 passed,
up from 130.
The demo profile seeds no assets, so the golden captures the empty state --
which still covers the header, heading, search row and status region, the
surface the overflow regression lived on.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
64 lines
1.9 KiB
TypeScript
64 lines
1.9 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
|
|
import { createTechLogServingContract } from "../../scripts/lib/tech-log-serving-contract.ts";
|
|
import {
|
|
projects,
|
|
publicRecords,
|
|
releases,
|
|
} from "../../src/features/tech-log/adapters/static/public-content.ts";
|
|
|
|
describe("TechLog production serving contract", () => {
|
|
it("derives every known Public path from the installed static content", () => {
|
|
const contract = createTechLogServingContract({
|
|
projects,
|
|
publicRecords,
|
|
releases,
|
|
});
|
|
|
|
expect(contract.publicSpaPaths).toEqual([
|
|
"/",
|
|
"/cases/collection-fetch-join-pagination",
|
|
"/cases/redis-adapter-ttl-boundary",
|
|
"/explore",
|
|
"/explore/cases",
|
|
"/explore/questions",
|
|
"/explore/references",
|
|
"/profile",
|
|
"/projects",
|
|
"/projects/auth-lab",
|
|
"/projects/auth-lab/activity",
|
|
"/projects/auth-lab/decisions",
|
|
"/projects/auth-lab/records",
|
|
"/projects/backend-skeleton",
|
|
"/projects/backend-skeleton/activity",
|
|
"/projects/backend-skeleton/decisions",
|
|
"/projects/backend-skeleton/records",
|
|
"/questions/collection-fetch-join-with-pagination",
|
|
"/questions/validate-edge-token-again",
|
|
"/references/jpa-list-fetch-strategy",
|
|
"/references/state-and-nonce-boundary",
|
|
"/releases",
|
|
"/releases/0.1.0",
|
|
"/search",
|
|
"/topics/authentication",
|
|
"/topics/jpa",
|
|
"/topics/redis",
|
|
]);
|
|
expect(contract.studioPathPrefix).toBe("/studio");
|
|
expect(contract.studioSpaPathPatterns).toEqual([
|
|
"^/studio$",
|
|
"^/studio/assets$",
|
|
"^/studio/documents$",
|
|
"^/studio/documents/new$",
|
|
"^/studio/documents/[^/]+/(edit|validation|preview|publish)$",
|
|
"^/studio/publications$",
|
|
"^/studio/publications/[^/]+/preview$",
|
|
]);
|
|
expect(contract.notFound).toEqual({
|
|
status: 404,
|
|
contentType: "text/plain;charset=UTF-8",
|
|
body: "Not Found",
|
|
});
|
|
});
|
|
});
|