Files
tech-log-frontend/scripts/check-app-build-input.ts
T
DongHyeonka 8422c41e76 fix(build): 번들 기능 소유 검사가 직접 조립하는 TechLog를 받아들인다
문제
FE-GATE-012의 check:app-build-input:bundle은 production 번들에 든
`src/features/<dir>/` 모듈이 모두 앱의 context가 소유한(생성기로 설치한)
기능이어야 한다고 본다. TechLog는 조립부가 직접 붙이는 기능이라
(`src/features/tech-log/NOT_INSTALLED`) 어떤 context도 소유하지 않는다.
그래서 이 검사는 TechLog의 모든 production 번들을 거절한다. 9-29 템플릿
동기화(af3d8e6)로 들어온 뒤, 같은 게이트의 번들 예산 검사가 먼저 실패해
한 번도 이 단계까지 가지 않았다. 예산을 맞추자 드러났다.

고른 방법
- DIRECTLY_COMPOSED_FEATURE_DIRECTORIES(["tech-log"])를 두고, 번들 쪽
  검사에서만 이름으로 허용한다.
- 생성 인덱스 쪽 검사는 그대로다. 생성기가 TechLog를 import하면 여전히
  실패한다.

버린 대안
- NOT_INSTALLED 표시가 있는 디렉터리를 모두 허용: reference-feature와
  local-draft-feature도 NOT_INSTALLED다. 그 샘플이 번들에 새면 이 검사가
  잡아야 한다.

위험·한계
- 템플릿 소유 스크립트를 고친다. TechLog를 feature-module.ts로 옮기는
  후속 작업(docs/operations/template-sync-2026-09-29.md)을 하면 이 목록을
  지운다.

검증
- tests/architecture/app-build-input.test.ts: TechLog 모듈은 받아들이고,
  같은 번들의 reference-feature는 거절한다.
- desktop CI env에서 이 커밋 전 head로 돌린 FE-GATE-012: 번들 예산은 PASS
  (229,223 / 230,400 B), check:app-build-input:bundle이 "production bundle
  contains feature \"tech-log\" not owned by app template-app"으로 실패.
2026-11-12 22:38:22 +09:00

160 lines
6.4 KiB
TypeScript

import { readFile } from "node:fs/promises";
import path from "node:path";
import {
createFileSystemDeclarationSource,
type TopologyDeclarationSource,
} from "./generate-product-feature-index.ts";
/**
* Spec §3 / §37. Build-input regression gate for deployable-app isolation.
*
* The app being built is the one recorded in `src/.generated/product-app.ts`.
* Its allowed features are exactly those owned (via their context) by that
* app's declarations. The gate fails when
* - a generated index imports a feature or declares a context outside that
* ownership set (e.g. a regression back to "import every src/features"),
* - the production bundle's module inventory contains a module of a feature
* the app does not own.
*/
export type AppBuildInputReport = Readonly<{
appId: string;
ownedContexts: readonly string[];
ownedFeatureDirectories: readonly string[];
generatedFeatureImports: readonly string[];
generatedContexts: readonly string[];
bundle: Readonly<{ checked: boolean; featureDirectories: readonly string[] }>;
violations: readonly string[];
}>;
/**
* Template sync (af3d8e6). TechLog is this product's own domain, composed
* directly by the composition root rather than by the index generator
* (`src/features/tech-log/NOT_INSTALLED`). No context owns it, so the
* template's ownership rule refused every production bundle of this product;
* FE-GATE-012 stopped at the bundle budget before reaching it, which hid that.
*
* It is allowed in the bundle by name only. The generated indexes still may not
* import it, and every other directory marked NOT_INSTALLED (the reference and
* local-draft samples) is still refused if it reaches the bundle.
*/
export const DIRECTLY_COMPOSED_FEATURE_DIRECTORIES: readonly string[] = Object.freeze([
"tech-log",
]);
const GENERATED = [
"src/.generated/product-feature-index.ts",
"src/.generated/product-context-index.ts",
"src/.generated/product-app.ts",
] as const;
function unique(values: Iterable<string>): string[] {
return [...new Set(values)].sort();
}
export async function inspectAppBuildInput(
root: string,
options: Readonly<{
source?: TopologyDeclarationSource;
bundleInventory?: string | null;
}> = {},
): Promise<AppBuildInputReport> {
const source = options.source ?? (await createFileSystemDeclarationSource(root));
const [featureIndex, contextIndex, appIndex] = await Promise.all(
GENERATED.map((file) => readFile(path.join(root, file), "utf8")),
);
const appId = /id:\s*"([^"]+)"/u.exec(appIndex ?? "")?.[1];
const violations: string[] = [];
if (!appId || !source.app(appId)) {
violations.push(`generated app ${appId ?? "<missing>"} is not a declared deployable app`);
}
const ownedContexts = appId ? source.contextsOf(appId).map((context) => context.id) : [];
const ownedFeatureDirectories = unique(
ownedContexts.flatMap((contextId) => source.featuresOf(contextId).map((feature) => feature.directory)),
);
const owned = new Set(ownedFeatureDirectories);
const featureDirectoriesIn = (text: string) =>
unique([...text.matchAll(/\.\.\/features\/([^/"']+)\//gu)].map((match) => match[1] as string));
const generatedFeatureImports = unique([
...featureDirectoriesIn(featureIndex ?? ""),
...featureDirectoriesIn(contextIndex ?? ""),
]);
for (const directory of generatedFeatureImports) {
if (!owned.has(directory)) {
violations.push(`generated index imports feature "${directory}" not owned by app ${appId}`);
}
}
const generatedContexts = unique(
[...(contextIndex ?? "").matchAll(/defineBoundedContextModule\(\{\s*id:\s*"([^"]+)"/gu)].map(
(match) => match[1] as string,
),
);
const ownedContextSet = new Set(ownedContexts);
for (const contextId of generatedContexts) {
if (!ownedContextSet.has(contextId)) {
violations.push(`generated index declares context "${contextId}" not owned by app ${appId}`);
}
}
let bundle: AppBuildInputReport["bundle"] = { checked: false, featureDirectories: [] };
const inventoryPath =
options.bundleInventory === undefined
? path.join(root, "artifacts/quality/vite-module-inventory.json")
: options.bundleInventory;
if (inventoryPath) {
const raw = await readFile(inventoryPath, "utf8").catch(() => null);
if (raw !== null) {
const inventory = JSON.parse(raw) as { chunks?: { modules?: string[] }[] };
const modules = (inventory.chunks ?? []).flatMap((chunk) => chunk.modules ?? []);
const featureDirectories = unique(
modules.flatMap((module) => {
const match = /^src\/features\/([^/]+)\//u.exec(module);
return match ? [match[1] as string] : [];
}),
);
bundle = { checked: true, featureDirectories };
const composedDirectly = new Set(DIRECTLY_COMPOSED_FEATURE_DIRECTORIES);
for (const directory of featureDirectories) {
if (!owned.has(directory) && !composedDirectly.has(directory)) {
violations.push(`production bundle contains feature "${directory}" not owned by app ${appId}`);
}
}
}
}
return Object.freeze({
appId: appId ?? "",
ownedContexts: unique(ownedContexts),
ownedFeatureDirectories,
generatedFeatureImports,
generatedContexts,
bundle,
violations,
});
}
async function main(): Promise<void> {
// The bundle inventory is only meaningful right after a build of this tree;
// without `--require-bundle` the gate checks the generated indexes only, so a
// stale inventory from another build can never pass or fail it.
const requireBundle = process.argv.includes("--require-bundle");
const report = await inspectAppBuildInput(process.cwd(), requireBundle ? {} : { bundleInventory: null });
if (requireBundle && !report.bundle.checked) {
process.stderr.write("app build input: no production module inventory; run the build first\n");
process.exit(1);
}
for (const violation of report.violations) process.stderr.write(`FAIL ${violation}\n`);
process.stdout.write(
`app build input: app=${report.appId} contexts=${report.ownedContexts.length} ` +
`features=${report.ownedFeatureDirectories.length} generatedImports=${report.generatedFeatureImports.length} ` +
`bundle=${report.bundle.checked ? `${report.bundle.featureDirectories.length} feature dirs` : "not checked"} ` +
`${report.violations.length === 0 ? "PASS" : "FAIL"}\n`,
);
if (report.violations.length > 0) process.exitCode = 1;
}
if (import.meta.url === `file://${process.argv[1]}`) {
await main();
}