test(fileserver): admin 유스케이스가 자기 접근 연산을 묻는지 시험한다 #87
+133
@@ -16,31 +16,43 @@ import dev.caskeleton.application.fileserver.api.security.FileOperation;
|
||||
import dev.caskeleton.application.fileserver.api.transfer.UploadMode;
|
||||
import dev.caskeleton.application.fileserver.cleanup.CleanupRequest;
|
||||
import dev.caskeleton.application.fileserver.cleanup.CleanupType;
|
||||
import dev.caskeleton.application.fileserver.cleanup.DefaultCleanupService;
|
||||
import dev.caskeleton.application.fileserver.observability.FileserverMetricsPort;
|
||||
import dev.caskeleton.application.fileserver.observability.SafeFileFingerprint;
|
||||
import dev.caskeleton.application.fileserver.port.in.CleanupUploadsCommand;
|
||||
import dev.caskeleton.application.fileserver.port.in.ForceDeleteCommand;
|
||||
import dev.caskeleton.application.fileserver.port.in.GetRuntimeCapabilitiesQuery;
|
||||
import dev.caskeleton.application.fileserver.port.in.GetStorageHealthQuery;
|
||||
import dev.caskeleton.application.fileserver.port.in.ListIncompleteUploadsQuery;
|
||||
import dev.caskeleton.application.fileserver.port.in.ListOrphansQuery;
|
||||
import dev.caskeleton.application.fileserver.port.in.OrphanReconcileCommand;
|
||||
import dev.caskeleton.application.fileserver.port.in.ReverifyFileCommand;
|
||||
import dev.caskeleton.application.fileserver.testkit.DirectTransactions;
|
||||
import dev.caskeleton.application.fileserver.testkit.FakeAdminPorts;
|
||||
import dev.caskeleton.application.fileserver.testkit.FakeCleanupContentGateway;
|
||||
import dev.caskeleton.application.fileserver.testkit.FakeFileAccessPolicy;
|
||||
import dev.caskeleton.application.fileserver.testkit.FakeFileQuotaService;
|
||||
import dev.caskeleton.application.fileserver.testkit.FileserverFixtures;
|
||||
import dev.caskeleton.application.fileserver.testkit.InMemoryCleanupQueue;
|
||||
import dev.caskeleton.application.fileserver.testkit.InMemoryFileMetadataStore;
|
||||
import dev.caskeleton.application.fileserver.testkit.InMemoryUploadSessionStore;
|
||||
import dev.caskeleton.application.fileserver.testkit.ReadyFileFixture;
|
||||
import dev.caskeleton.application.fileserver.testkit.RecordingQuotaReclaimGateway;
|
||||
import java.nio.charset.StandardCharsets;
|
||||
import java.time.Clock;
|
||||
import java.time.Duration;
|
||||
import java.time.ZoneOffset;
|
||||
import java.util.List;
|
||||
import java.util.Optional;
|
||||
import java.util.OptionalLong;
|
||||
import java.util.Set;
|
||||
import java.util.UUID;
|
||||
import org.junit.jupiter.api.Test;
|
||||
|
||||
class FileserverAdminUseCasesTest {
|
||||
|
||||
private static final String DIGEST = "1".repeat(64);
|
||||
private static final String OTHER_DIGEST = "2".repeat(64);
|
||||
private static final long SIZE = 10;
|
||||
private static final ContentKey ORPHAN_KEY = ContentKey.of("aa/bb/orphan-object-0001");
|
||||
|
||||
@@ -74,6 +86,28 @@ class FileserverAdminUseCasesTest {
|
||||
new ForceDeleteFileApplicationUseCase(
|
||||
metadata, sessions, sessions, queue, accessPolicy, audit, new DirectTransactions());
|
||||
|
||||
private final ListOrphansApplicationUseCase listOrphans =
|
||||
new ListOrphansApplicationUseCase(adminPorts, accessPolicy);
|
||||
|
||||
private final ListIncompleteUploadsApplicationUseCase listIncompleteUploads =
|
||||
new ListIncompleteUploadsApplicationUseCase(
|
||||
sessions, accessPolicy, new DirectTransactions(), clock);
|
||||
|
||||
private final CleanupUploadsApplicationUseCase cleanupUploads =
|
||||
new CleanupUploadsApplicationUseCase(
|
||||
new DefaultCleanupService(
|
||||
queue,
|
||||
new FakeCleanupContentGateway(),
|
||||
metadata,
|
||||
sessions,
|
||||
new RecordingQuotaReclaimGateway(new FakeFileQuotaService()),
|
||||
Duration.ofMinutes(5),
|
||||
FileserverMetricsPort.noop(),
|
||||
new DirectTransactions(),
|
||||
clock),
|
||||
accessPolicy,
|
||||
audit);
|
||||
|
||||
@Test
|
||||
void capabilitiesNeverDiscloseAPhysicalRoot() {
|
||||
RuntimeCapabilityReport report =
|
||||
@@ -166,6 +200,62 @@ class FileserverAdminUseCasesTest {
|
||||
assertThat(report.reclaimedBytes()).isEqualTo(100);
|
||||
}
|
||||
|
||||
/** Echoed fingerprints are the caller's claim, not authority: denied, nothing leaves storage. */
|
||||
@Test
|
||||
void anOrphanApplyWithoutTheSecondAuthorityRemovesNothing() {
|
||||
// given
|
||||
adminPorts.addOrphan(new OrphanObject(ORPHAN_KEY, 100, FileserverFixtures.NOW, "fp-1"));
|
||||
accessPolicy.deny(FileOperation.ADMIN_FORCE_DELETE);
|
||||
|
||||
// when
|
||||
Throwable failure =
|
||||
catchThrowable(
|
||||
() ->
|
||||
reconcile.handle(
|
||||
new OrphanReconcileCommand(
|
||||
false,
|
||||
100,
|
||||
1L << 20,
|
||||
List.of("fp-1"),
|
||||
"OPERATOR_APPLY",
|
||||
FileserverFixtures.context())));
|
||||
|
||||
// then
|
||||
assertThat(failure)
|
||||
.isInstanceOf(FileserverException.class)
|
||||
.hasMessage("operation denied by policy");
|
||||
assertThat(List.of(adminPorts.deletedObjectCount(), adminPorts.quarantined(), queue.queued()))
|
||||
.as("[deleted objects, quarantined keys, queued cleanup]")
|
||||
.containsExactly(0, Set.of(), List.of());
|
||||
}
|
||||
|
||||
/**
|
||||
* A cleanup batch deletes what the queue names, so refusing it must leave the queue unclaimed.
|
||||
*/
|
||||
@Test
|
||||
void anUploadCleanupWithoutTheSecondAuthorityClaimsNothing() {
|
||||
// given
|
||||
CleanupRequest pending = CleanupRequest.forOrphan(ORPHAN_KEY);
|
||||
queue.enqueue(pending);
|
||||
accessPolicy.deny(FileOperation.ADMIN_FORCE_DELETE);
|
||||
|
||||
// when
|
||||
Throwable failure =
|
||||
catchThrowable(
|
||||
() ->
|
||||
cleanupUploads.handle(
|
||||
CleanupUploadsCommand.requested(
|
||||
Optional.empty(), Optional.empty(), FileserverFixtures.context())));
|
||||
|
||||
// then
|
||||
assertThat(failure)
|
||||
.isInstanceOf(FileserverException.class)
|
||||
.hasMessage("operation denied by policy");
|
||||
assertThat(List.of(queue.claimSweeps(), queue.queued()))
|
||||
.as("[claim sweeps, queued cleanup]")
|
||||
.containsExactly(List.of(), List.of(pending));
|
||||
}
|
||||
|
||||
@Test
|
||||
void anApplyWithoutFingerprintsCannotEvenBeConstructed() {
|
||||
assertThatThrownBy(
|
||||
@@ -310,6 +400,49 @@ class FileserverAdminUseCasesTest {
|
||||
.satisfies(record -> assertThat(record.actorFingerprint()).isNotEqualTo("user-1"));
|
||||
}
|
||||
|
||||
/**
|
||||
* {@link FileOperation} promises each entry point consults exactly one operation. The fake allows
|
||||
* everything, so only the order it was asked in shows a dropped check or one that asks for the
|
||||
* wrong tier; the production policy grouping these tiers together would hide both.
|
||||
*/
|
||||
@Test
|
||||
void everyAdminOperationConsultsItsOwnAccessOperation() {
|
||||
// given
|
||||
FileRecord quarantined = quarantinedRecord();
|
||||
FileRecord ready = ReadyFileFixture.ready(metadata, SIZE, OTHER_DIGEST);
|
||||
|
||||
// when
|
||||
callEveryAdminOperationOnce(quarantined.fileId(), ready.fileId());
|
||||
|
||||
// then
|
||||
assertThat(accessPolicy.invocations())
|
||||
.containsExactly(
|
||||
FileOperation.ADMIN_READ, // capabilities
|
||||
FileOperation.ADMIN_READ, // storage health
|
||||
FileOperation.ADMIN_READ, // orphan listing
|
||||
FileOperation.ADMIN_READ, // incomplete-upload listing
|
||||
FileOperation.ADMIN_REVERIFY, // reverify
|
||||
FileOperation.ADMIN_FORCE_DELETE, // orphan reconcile
|
||||
FileOperation.ADMIN_FORCE_DELETE, // upload cleanup
|
||||
FileOperation.ADMIN_FORCE_DELETE); // force delete
|
||||
}
|
||||
|
||||
/** One call per admin use case, in the order the assertion above names them. */
|
||||
private void callEveryAdminOperationOnce(FileId quarantinedFile, FileId readyFile) {
|
||||
capabilities.handle(new GetRuntimeCapabilitiesQuery(FileserverFixtures.context()));
|
||||
storageHealth.handle(new GetStorageHealthQuery(FileserverFixtures.context()));
|
||||
listOrphans.handle(ListOrphansQuery.requested(Optional.empty(), FileserverFixtures.context()));
|
||||
listIncompleteUploads.handle(
|
||||
ListIncompleteUploadsQuery.requested(Optional.empty(), FileserverFixtures.context()));
|
||||
reverify.handle(new ReverifyFileCommand(quarantinedFile, FileserverFixtures.context()));
|
||||
reconcile.handle(OrphanReconcileCommand.dryRun(100, FileserverFixtures.context()));
|
||||
cleanupUploads.handle(
|
||||
CleanupUploadsCommand.requested(
|
||||
Optional.empty(), Optional.empty(), FileserverFixtures.context()));
|
||||
forceDelete.handle(
|
||||
new ForceDeleteCommand(readyFile, "LEGAL_TAKEDOWN_2026_08", FileserverFixtures.context()));
|
||||
}
|
||||
|
||||
private FileRecord quarantinedRecord() {
|
||||
FileRecord verifying = ReadyFileFixture.verifying(metadata, SIZE, DIGEST);
|
||||
return metadata.transition(
|
||||
|
||||
Reference in New Issue
Block a user