fix(presentation): re-translate form errors on locale change (08-10)

The form kept translated strings in state, so errors already on screen stayed
in the old language. It now keeps message keys and translates on render.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
donghyeon-ka
2026-09-27 12:58:46 +09:00
co-authored by Claude Opus 5.5
parent 9d61eacdc7
commit ee9b09563a
2 changed files with 101 additions and 12 deletions
+30 -12
View File
@@ -43,7 +43,7 @@ export function useAppForm<
Command,
Output,
>(options: AppFormOptions<Values, Command, Output>) {
const { message } = useLocale();
const { resolve } = useLocale();
const {
schema,
defaultValues,
@@ -59,10 +59,28 @@ export function useAppForm<
const [touched, setTouched] = useState<ReadonlySet<FieldName<Values>>>(
() => new Set(),
);
const [fieldErrors, setFieldErrors] = useState<FieldErrors<Values>>(
// 08-10. Errors are held as message keys and translated on render, so a
// locale change re-translates the ones already on screen.
const [fieldErrorKeys, setFieldErrors] = useState<FieldErrors<Values>>(
() => ({} as FieldErrors<Values>),
);
const [formErrors, setFormErrors] = useState<readonly string[]>([]);
const [formErrorKeys, setFormErrors] = useState<readonly string[]>([]);
const fieldErrors = useMemo(
() =>
Object.freeze(
Object.fromEntries(
Object.entries(fieldErrorKeys).map(([name, key]) => [
name,
resolve(String(key)),
]),
),
) as FieldErrors<Values>,
[fieldErrorKeys, resolve],
);
const formErrors = useMemo(
() => formErrorKeys.map((key) => resolve(key)),
[formErrorKeys, resolve],
);
const [pending, setPending] = useState(false);
const [result, setResult] = useState<FormResultState>("idle");
const [statusFailure, setStatusFailure] = useState<AppFailure | null>(null);
@@ -188,7 +206,7 @@ export function useAppForm<
const mapped = mapValidationFailureToFields<Values>(
outcome.error,
allowedServerFields,
message,
messageKey,
);
setFieldErrors(mapped.fieldErrors);
setFormErrors(mapped.formErrors);
@@ -208,9 +226,7 @@ export function useAppForm<
settleSuccessfulValues(submittedValues);
} else if (outcome.error.kind === "CONFLICT") {
unknownSubmissionRef.current = null;
setFormErrors([
message("form.conflict"),
]);
setFormErrors(["form.conflict"]);
setResult("conflict");
} else if (
outcome.error.kind === "FORBIDDEN" ||
@@ -224,11 +240,11 @@ export function useAppForm<
);
} else {
unknownSubmissionRef.current = null;
setFormErrors([message("form.unavailable")]);
setFormErrors(["form.unavailable"]);
setResult("unavailable");
}
},
[allowedServerFields, focusFirstError, message, settleSuccessfulValues],
[allowedServerFields, focusFirstError, settleSuccessfulValues],
);
const validateAndSubmit = useCallback(
@@ -241,14 +257,14 @@ export function useAppForm<
const errors = issuesToFieldErrors<Values>(
parsed.error.issues,
allowedServerFields,
message,
messageKey,
);
setFieldErrors(errors);
setFormErrors(
parsed.error.issues.some(
(issue) => !allowedServerFields.includes(issue.path[0] as FieldName<Values>),
)
? [message("form.validation.configuration")]
? ["form.validation.configuration"]
: [],
);
setTouched(new Set(allowedServerFields));
@@ -272,7 +288,6 @@ export function useAppForm<
applyOutcome,
focusFirstError,
mapToCommand,
message,
schema,
submit,
values,
@@ -349,6 +364,9 @@ export function useAppForm<
});
}
/** Keeps the key: the form translates at render time. */
const messageKey = (key: ParameterlessMessageKey): string => key;
const STATUS_RESULTS: ReadonlySet<FormResultState> = new Set([
"reauth-required",
"forbidden",
+71
View File
@@ -4,6 +4,7 @@ import { render, screen } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { useState } from "react";
import { describe, expect, it } from "vitest";
import { z } from "zod";
import {
Button,
@@ -16,6 +17,12 @@ import {
useLocale,
type SupportedLocale,
} from "../../src/presentation/i18n/index.ts";
import {
ErrorSummary,
Form,
FormField,
useAppForm,
} from "../../src/presentation/forms/index.ts";
import { ApplicationProvider } from "../../src/presentation/providers/application-provider.tsx";
import { PreferenceProviders } from "../../src/presentation/providers/preference-providers.tsx";
import { AppRouter } from "../../src/presentation/routes/app-router.tsx";
@@ -54,7 +61,71 @@ function LocaleHarness() {
);
}
function LocaleSelect() {
const { locale, message, setLocale } = useLocale();
return (
<>
<label htmlFor="form-locale">{message("shell.locale")}</label>
<select
id="form-locale"
onChange={(event) =>
setLocale(event.currentTarget.value as SupportedLocale)
}
value={locale}
>
<option value="ko-KR">한국어</option>
<option value="en-US">English</option>
</select>
</>
);
}
function ValidatedForm() {
const form = useAppForm({
schema: z.object({ name: z.string().min(2) }).strict(),
defaultValues: { name: "" },
allowedServerFields: ["name"],
mapToCommand: (values) => values,
submit: async () => ({ ok: true as const, value: null }),
});
return (
<Form onSubmit={(event) => void form.submitForm(event)}>
<ErrorSummary
fieldErrors={form.fieldErrors}
formErrors={form.formErrors}
fieldLabels={{ name: "Name" }}
fieldId={form.fieldId}
/>
<FormField {...form.field("name")} label="Name" />
<button type="submit">Submit</button>
</Form>
);
}
describe("locale provider runtime", () => {
// 08-10. A shown error is kept as a message key, not a translated string.
it("re-translates displayed form errors when the locale changes", async () => {
const user = userEvent.setup();
render(
<LocaleProvider>
<LocaleSelect />
<ValidatedForm />
</LocaleProvider>,
);
await user.click(screen.getByRole("button", { name: "Submit" }));
expect(screen.getByRole("alert")).toHaveTextContent(
"입력 내용을 확인해 주세요.Name: 입력값이 너무 짧습니다.",
);
await user.selectOptions(screen.getByLabelText("언어"), "en-US");
expect(screen.getByRole("alert")).toHaveTextContent(
"Review the entered information.Name: This value is too short.",
);
expect(screen.getByRole("textbox", { name: "Name" })).toHaveAccessibleDescription(
"This value is too short.",
);
});
it("switches copy and synchronizes the document language and direction", async () => {
const user = userEvent.setup();
render(