frontend-quality-gates / merge / static checks (pull_request) Successful in 1m33s
frontend-quality-gates / merge / tests (pull_request) Successful in 12m9s
frontend-quality-gates / merge / browser tests (pull_request) Successful in 5m35s
frontend-quality-gates / FE-GATE-017 / diagram-review (pull_request) Skipped
frontend-quality-gates / main / self-tests and removal drills (pull_request) Skipped
frontend-quality-gates / FE-GATE-014 / config-compatibility (pull_request) Skipped
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (pull_request) Skipped
frontend-quality-gates / FE-GATE-026 / lab-performance (pull_request) Skipped
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (pull_request) Skipped
frontend-quality-gates / external-vulnerability-provider (pull_request) Skipped
frontend-quality-gates / external-provenance-provider (pull_request) Skipped
frontend-quality-gates / promote-verified-immutable-candidate (pull_request) Skipped
frontend-quality-gates / deploy-promoted-release (pull_request) Skipped
frontend-quality-gates / FE-GATE-019 / hosting-header (pull_request) Skipped
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (pull_request) Skipped
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (pull_request) Skipped
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (pull_request) Skipped
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (pull_request) Skipped
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (pull_request) Skipped
frontend-quality-gates / FE-GATE-018 / field-web-vitals (pull_request) Skipped
PR run의 merge job은 CI_PR_BASE_REF=main을 둔다. 임시 폴더에서 scripts/run-ci-gate.ts를 띄우는 시험은 env를 그대로 물려줬고, 자식은 그 폴더에 없는 config/ci/pr-gate-selection.json을 열다 ENOENT로 죽었다(runner run 291, tests/unit/ci-gate-failure.test.ts:102). FE-GATE-005가 깨졌고, scaffold 사본의 test:coverage가 같은 시험을 돌려 FE-GATE-020도 깨졌다. desktop verify.sh merge는 ci_env에 이 변수가 없어 이 길을 타지 않았다. fixture는 PR의 checkout이 아니므로 그 안의 게이트는 늘 전부 돈다. FIXTURE_PNPM_ENVIRONMENT가 CI_PR_BASE_REF를 빈 값(main run과 같음)으로 둔다. scaffold 드릴·제거 드릴·provider fixture·run-ci-gate를 띄우는 시험이 모두 이 상수를 쓰므로 한 곳에서 끈다. - ci-gate-failure 시험은 바깥 env와 상관없이 PR job env(main)를 넣고 띄운다. 그래서 desktop에서도 CI의 조건을 늘 시험한다. - run-ci-gate를 띄우는 시험은 이 상수를 써야 한다는 검사를 fixture-node-modules 시험에 더했다. 그 검사가 상수 없이 띄우던 ci-workflow-generation 시험 하나를 찾았다. 그 시험은 preflight에서 먼저 막혀 지금은 가려지지 않지만, 상수를 주고 막힌 이유를 단언한다. 버린 대안: - prGateSkipReason이 경로표가 없으면 전부 돌기: 원인은 시험 env다. 진짜 checkout에서 경로표가 없으면 크게 실패하는 편이 맞다. - verify.sh ci_env에 CI_PR_BASE_REF를 두기: desktop merge가 게이트를 건너뛰게 되어 「merge 단계 전부 통과」 판정과 맞지 않는다. 위험·한계: - 시스템 컨테이너(scripts/run-in-system-container.sh)는 CI_PR_BASE_REF를 넘기지 않는다. 그래서 FE-GATE-013은 PR run에서도 늘 전부 돈다(안전한 쪽). 이 커밋은 그대로 둔다. 검증(desktop): - RED: 9f8b2c1c에서 `env CI_PR_BASE_REF=main node scripts/run-vitest.ts run tests/unit/ci-gate-failure.test.ts` rc=1, run 291과 같은 ENOENT. - 고친 뒤 시험 4파일(ci-gate-failure, fixture-node-modules, pr-gate-selection, ci-workflow-generation) 471개 통과, 바깥 CI_PR_BASE_REF=main 있을 때와 없을 때 둘 다. - 상수의 새 줄만 빼면 바깥 env 없이도 ci-gate-failure 시험이 같은 ENOENT로 실패한다. 새 검사는 상수를 안 쓰던 시험을 찾아 실패했다.
90 lines
4.0 KiB
TypeScript
90 lines
4.0 KiB
TypeScript
import { copyFile, mkdir, readdir, readFile, stat, symlink, writeFile } from "node:fs/promises";
|
|
import path from "node:path";
|
|
|
|
import { PR_BASE_REF_VARIABLE } from "./pr-gate-selection.ts";
|
|
|
|
/**
|
|
* Links the repository's installed dependencies into a throwaway fixture root.
|
|
*
|
|
* The obvious form — one directory symlink at `<fixture>/node_modules` — is
|
|
* destructive. A fixture runs `pnpm` inside itself, pnpm does not recognise the
|
|
* modules directory it finds there, and its purge follows the symlink and
|
|
* deletes the *repository's* real dependencies mid-run. With `CI=true` that
|
|
* happens without a prompt, so a test suite silently uninstalls the workspace
|
|
* it is running in.
|
|
*
|
|
* `node_modules` is therefore a real directory here, and every entry inside it
|
|
* is an individual symlink. Package resolution is unchanged, but a recursive
|
|
* delete unlinks the fixture's own symlinks instead of walking through one link
|
|
* into the shared tree.
|
|
*
|
|
* Top-level files are pnpm's install state (`.modules.yaml`,
|
|
* `.pnpm-workspace-state-v1.json`, ...). pnpm rewrites them in place when it
|
|
* runs inside the fixture, so they are copied: a link would carry the fixture's
|
|
* path into the repository's own state and make its next pnpm command
|
|
* re-verify the install.
|
|
*
|
|
* The copied workspace state still names the repository as its validated
|
|
* project, so pnpm in the fixture would re-verify and start an install through
|
|
* the linked directories. It is rewritten to name the fixture root instead:
|
|
* the packages are the repository's own, already validated.
|
|
*/
|
|
/**
|
|
* F-4. The environment for every `pnpm` a linked fixture runs. pnpm verifies
|
|
* the install before a script and, when the fixture's copied state disagrees
|
|
* with its own settings (for example `CI=true` against an install made
|
|
* without it), installs. `.pnpm` and `.bin` are links into the repository's
|
|
* node_modules, so that install rewrote the shared `.pnpm/lock.yaml` and bin
|
|
* shims. A fixture started through `pnpm <script>` inherits this setting from
|
|
* pnpm; one started directly (`node scripts/run-vitest.ts run <file>`) did not.
|
|
* The fixture uses the repository's packages as they are; it never installs.
|
|
*
|
|
* A fixture is not the PR's checkout either, so it runs with the PR gate
|
|
* selection off (`CI_PR_BASE_REF` empty, as in a main run). A PR run's merge
|
|
* jobs set it, and a fixture that inherited it ran `scripts/run-ci-gate.ts`
|
|
* against a path table the fixture root does not have (runner run 291: ENOENT
|
|
* on config/ci/pr-gate-selection.json, FE-GATE-005 and, through the scaffold
|
|
* copy's coverage run, FE-GATE-020). A gate a fixture runs always runs; a
|
|
* test of the selection itself sets the variable after this spread.
|
|
*/
|
|
export const FIXTURE_PNPM_ENVIRONMENT = Object.freeze({
|
|
pnpm_config_verify_deps_before_run: "false",
|
|
[PR_BASE_REF_VARIABLE]: "",
|
|
});
|
|
|
|
export async function linkFixtureNodeModules(
|
|
fixtureRoot: string,
|
|
sourceRoot: string = process.cwd(),
|
|
): Promise<void> {
|
|
const source = path.join(sourceRoot, "node_modules");
|
|
const target = path.join(fixtureRoot, "node_modules");
|
|
await mkdir(target, { recursive: true });
|
|
for (const entry of await readdir(source)) {
|
|
const from = path.join(source, entry);
|
|
const to = path.join(target, entry);
|
|
if ((await stat(from)).isDirectory()) await symlink(from, to, "dir");
|
|
else await copyFile(from, to);
|
|
}
|
|
await retargetWorkspaceState(
|
|
path.join(target, ".pnpm-workspace-state-v1.json"),
|
|
fixtureRoot,
|
|
);
|
|
}
|
|
|
|
async function retargetWorkspaceState(
|
|
statePath: string,
|
|
fixtureRoot: string,
|
|
): Promise<void> {
|
|
let state: { projects?: Record<string, unknown>; lastValidatedTimestamp?: number };
|
|
try {
|
|
state = JSON.parse(await readFile(statePath, "utf8"));
|
|
} catch {
|
|
return; // no state file, or not pnpm's JSON: nothing to retarget
|
|
}
|
|
const [project] = Object.values(state.projects ?? {});
|
|
if (project === undefined) return;
|
|
state.projects = { [fixtureRoot]: project };
|
|
state.lastValidatedTimestamp = Date.now();
|
|
await writeFile(statePath, `${JSON.stringify(state, null, 2)}\n`);
|
|
}
|